IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: More typescript strict null fixes, going for sub 200 (#26134)

Browse Source 
* Chore: Fix typescript strict null errors

* Added new limit

* Fixed ts issue

* fixed tests

* trying to fix type inference

* Fixing more ts errors

* Revert tsconfig option

* Fix

* Fixed code

* More fixes

* fix tests

* Updated snapshot

* Chore: More ts strict null fixes

* More fixes in some really messed up azure config components

* More fixes, current count: 441

* 419

* More fixes

* Fixed invalid initial state in explore

* Fixing tests

* Fixed tests

* Explore fix

* More fixes

* Progress

* Sub 300

* Now at 218

* Progress

* Update

* Progress

* Updated tests

* at 159

* fixed tests

* Fixed test
This commit is contained in:
Torkel Ödegaard
2020-07-09 15:16:35 +02:00
committed by GitHub
parent 9285595c50
commit 49b5fc4b9a
66 changed files with 292 additions and 283 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
public/app/features/dashboard/state/PanelModel.ts
View File

@@ -116,7 +116,7 @@ export class PanelModel implements DataConfigSource {
soloMode?: boolean;
targets: DataQuery[];
transformations?: DataTransformerConfig[];
datasource: string;
datasource: string | null;
thresholds?: any;
pluginVersion?: string;
@@ -352,7 +352,7 @@ export class PanelModel implements DataConfigSource {
const pluginId = newPlugin.meta.id;
const oldOptions: any = this.getOptionsToRemember();
const oldPluginId = this.type;
const wasAngular = !!this.plugin.angularPanelCtrl;
const wasAngular = this.isAngularPlugin();
// remove panel type specific options
for (const key of _.keys(this)) {
@@ -458,7 +458,7 @@ export class PanelModel implements DataConfigSource {
}
isAngularPlugin(): boolean {
return this.plugin && !!this.plugin.angularPanelCtrl;
return (this.plugin && this.plugin.angularPanelCtrl) !== undefined;
}
destroy() {