Alerting: Update useAsync to typeguard states (#98884)

public/app/features/alerting/unified/hooks/useAsync.tsx

@@ -8,23 +8,31 @@ import { stringifyErrorLike } from '../utils/misc';
 export type AsyncStatus = 'loading' | 'success' | 'error' | 'not-executed';
 
 export type AsyncState<Result> =
-  | {
+  | AsyncStateUninitialized<Result>
-      status: 'not-executed';
+  | AsyncStateFulfilled<Result>
-      error: undefined;
+  | AsyncStateWithError<Result>
-      result: Result;
+  | AsyncStateLoading<Result>;
-    }
+
-  | {
+export type AsyncStateWithError<Result> = {
-      status: 'success';
-      error: undefined;
-      result: Result;
-    }
-  | {
   status: 'error';
   error: Error;
   result: Result;
-    }
+};
-  | {
+
-      status: AsyncStatus;
+export type AsyncStateFulfilled<Result> = {
+  status: 'success';
+  error: undefined;
+  result: Result;
+};
+
+export type AsyncStateUninitialized<Result> = {
+  status: 'not-executed';
+  error: undefined;
+  result: Result;
+};
+
+export type AsyncStateLoading<Result> = {
+  status: 'loading';
   error: Error | undefined;
   result: Result;
 };
@@ -157,19 +165,19 @@ function useSyncedRef<T>(value: T): { readonly current: T } {
 
 // --- utility functions to help with request state assertions ---
 
-export function isError<T>(state: AsyncState<T>) {
+export function isError<T>(state: AsyncState<unknown>): state is AsyncStateWithError<T> {
   return state.status === 'error';
 }
 
-export function isSuccess<T>(state: AsyncState<T>) {
+export function isSuccess<T>(state: AsyncState<T>): state is AsyncStateFulfilled<T> {
   return state.status === 'success';
 }
 
-export function isUninitialized<T>(state: AsyncState<T>) {
+export function isUninitialized<T>(state: AsyncState<T>): state is AsyncStateUninitialized<T> {
   return state.status === 'not-executed';
 }
 
-export function isLoading<T>(state: AsyncState<T>) {
+export function isLoading<T>(state: AsyncState<T>): state is AsyncStateLoading<T> {
   return state.status === 'loading';
 }
 
@@ -185,7 +193,7 @@ export function anyOfRequestState(...states: Array<AsyncState<unknown>>) {
 /**
  * This is only used for testing and serializing the async state
  */
-export function SerializeState({ state }: { state: AsyncState<unknown> }) {
+export function SerializeState<T>({ state }: { state: AsyncState<T> }) {
   return (
     <>
       {isUninitialized(state) && 'uninitialized'}