From 4b889eb33671cda1929d72683c508f6a63642500 Mon Sep 17 00:00:00 2001 From: Shirley <4163034+fridgepoet@users.noreply.github.com> Date: Tue, 12 Apr 2022 16:22:28 +0200 Subject: [PATCH] Change to pointer receiver in mock call (#47575) --- pkg/tsdb/cloudwatch/metric_find_query_test.go | 6 +++--- pkg/tsdb/cloudwatch/time_series_query_test.go | 2 +- pkg/tsdb/cloudwatch/utils_test.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/tsdb/cloudwatch/metric_find_query_test.go b/pkg/tsdb/cloudwatch/metric_find_query_test.go index 223a0869c8d..520d52d60a7 100644 --- a/pkg/tsdb/cloudwatch/metric_find_query_test.go +++ b/pkg/tsdb/cloudwatch/metric_find_query_test.go @@ -32,7 +32,7 @@ func TestQuery_Metrics(t *testing.T) { var cwClient fakeCWClient NewCWClient = func(sess *session.Session) cloudwatchiface.CloudWatchAPI { - return cwClient + return &cwClient } t.Run("Custom metrics", func(t *testing.T) { @@ -403,7 +403,7 @@ func TestQuery_GetDimensionKeys(t *testing.T) { var client fakeCWClient NewCWClient = func(sess *session.Session) cloudwatchiface.CloudWatchAPI { - return client + return &client } metrics := []*cloudwatch.Metric{ @@ -527,7 +527,7 @@ func TestQuery_ListMetricsPagination(t *testing.T) { var client fakeCWClient NewCWClient = func(sess *session.Session) cloudwatchiface.CloudWatchAPI { - return client + return &client } metrics := []*cloudwatch.Metric{ diff --git a/pkg/tsdb/cloudwatch/time_series_query_test.go b/pkg/tsdb/cloudwatch/time_series_query_test.go index 7c55c4d2459..72c12e6dc17 100644 --- a/pkg/tsdb/cloudwatch/time_series_query_test.go +++ b/pkg/tsdb/cloudwatch/time_series_query_test.go @@ -30,7 +30,7 @@ func TestTimeSeriesQuery(t *testing.T) { var cwClient fakeCWClient NewCWClient = func(sess *session.Session) cloudwatchiface.CloudWatchAPI { - return cwClient + return &cwClient } t.Run("Custom metrics", func(t *testing.T) { diff --git a/pkg/tsdb/cloudwatch/utils_test.go b/pkg/tsdb/cloudwatch/utils_test.go index e6bf1156535..9f1213ed435 100644 --- a/pkg/tsdb/cloudwatch/utils_test.go +++ b/pkg/tsdb/cloudwatch/utils_test.go @@ -67,11 +67,11 @@ type fakeCWClient struct { MetricsPerPage int } -func (c fakeCWClient) GetMetricDataWithContext(aws.Context, *cloudwatch.GetMetricDataInput, ...request.Option) (*cloudwatch.GetMetricDataOutput, error) { +func (c *fakeCWClient) GetMetricDataWithContext(aws.Context, *cloudwatch.GetMetricDataInput, ...request.Option) (*cloudwatch.GetMetricDataOutput, error) { return &c.GetMetricDataOutput, nil } -func (c fakeCWClient) ListMetricsPages(input *cloudwatch.ListMetricsInput, fn func(*cloudwatch.ListMetricsOutput, bool) bool) error { +func (c *fakeCWClient) ListMetricsPages(input *cloudwatch.ListMetricsInput, fn func(*cloudwatch.ListMetricsOutput, bool) bool) error { if c.MetricsPerPage == 0 { c.MetricsPerPage = 1000 }