diff --git a/pkg/tsdb/elasticsearch/client/client.go b/pkg/tsdb/elasticsearch/client/client.go index c89056ac7ee..d0ebe7130e1 100644 --- a/pkg/tsdb/elasticsearch/client/client.go +++ b/pkg/tsdb/elasticsearch/client/client.go @@ -308,20 +308,12 @@ func (c *baseClientImpl) createMultiSearchRequests(searchRequests []*SearchReque } func (c *baseClientImpl) getMultiSearchQueryParameters() string { - var qs []string - if c.version >= 70 { maxConcurrentShardRequests := c.getSettings().Get("maxConcurrentShardRequests").MustInt(5) - qs = append(qs, fmt.Sprintf("max_concurrent_shard_requests=%d", maxConcurrentShardRequests)) - - includeFrozen := c.getSettings().Get("includeFrozen").MustBool(false) - - if includeFrozen { - qs = append(qs, "ignore_throttled=false") - } + return fmt.Sprintf("max_concurrent_shard_requests=%d", maxConcurrentShardRequests) } - return strings.Join(qs, "&") + return "" } func (c *baseClientImpl) MultiSearch() *MultiSearchRequestBuilder { diff --git a/pkg/tsdb/elasticsearch/client/client_test.go b/pkg/tsdb/elasticsearch/client/client_test.go index 222272a33f1..993310d6beb 100644 --- a/pkg/tsdb/elasticsearch/client/client_test.go +++ b/pkg/tsdb/elasticsearch/client/client_test.go @@ -250,7 +250,6 @@ func TestClient(t *testing.T) { "maxConcurrentShardRequests": 100, "timeField": "@timestamp", "interval": "Daily", - "includeFrozen": true, }), }, func(sc *scenarioContext) { sc.responseBody = `{ @@ -272,7 +271,6 @@ func TestClient(t *testing.T) { So(sc.request, ShouldNotBeNil) So(sc.request.Method, ShouldEqual, http.MethodPost) So(sc.request.URL.Path, ShouldEqual, "/_msearch") - So(sc.request.URL.RawQuery, ShouldNotContainSubstring, "ignore_throttled=") So(sc.requestBody, ShouldNotBeNil) @@ -314,7 +312,6 @@ func TestClient(t *testing.T) { "maxConcurrentShardRequests": 6, "timeField": "@timestamp", "interval": "Daily", - "includeFrozen": true, }), }, func(sc *scenarioContext) { sc.responseBody = `{ @@ -336,8 +333,7 @@ func TestClient(t *testing.T) { So(sc.request, ShouldNotBeNil) So(sc.request.Method, ShouldEqual, http.MethodPost) So(sc.request.URL.Path, ShouldEqual, "/_msearch") - So(sc.request.URL.RawQuery, ShouldContainSubstring, "max_concurrent_shard_requests=6") - So(sc.request.URL.RawQuery, ShouldContainSubstring, "ignore_throttled=false") + So(sc.request.URL.RawQuery, ShouldEqual, "max_concurrent_shard_requests=6") So(sc.requestBody, ShouldNotBeNil) @@ -354,7 +350,6 @@ func TestClient(t *testing.T) { So(jHeader.Get("index").MustString(), ShouldEqual, "metrics-2018.05.15") So(jHeader.Get("ignore_unavailable").MustBool(false), ShouldEqual, true) So(jHeader.Get("search_type").MustString(), ShouldEqual, "query_then_fetch") - So(jHeader.Get("ignore_throttled").MustBool(), ShouldBeFalse) Convey("and replace $__interval variable", func() { So(jBody.GetPath("aggs", "2", "aggs", "1", "avg", "script").MustString(), ShouldEqual, "15000*@hostname") diff --git a/public/app/plugins/datasource/elasticsearch/configuration/ConfigEditor.tsx b/public/app/plugins/datasource/elasticsearch/configuration/ConfigEditor.tsx index 328d0696b81..9d6e87e8f72 100644 --- a/public/app/plugins/datasource/elasticsearch/configuration/ConfigEditor.tsx +++ b/public/app/plugins/datasource/elasticsearch/configuration/ConfigEditor.tsx @@ -18,7 +18,6 @@ export const ConfigEditor = (props: Props) => { jsonData: { ...options.jsonData, timeField: options.jsonData.timeField || '@timestamp', - includeFrozen: options.jsonData.includeFrozen ?? false, esVersion, maxConcurrentShardRequests: options.jsonData.maxConcurrentShardRequests || defaultMaxConcurrentShardRequests(esVersion), diff --git a/public/app/plugins/datasource/elasticsearch/configuration/ElasticDetails.tsx b/public/app/plugins/datasource/elasticsearch/configuration/ElasticDetails.tsx index 7cf35144874..2c26f3007db 100644 --- a/public/app/plugins/datasource/elasticsearch/configuration/ElasticDetails.tsx +++ b/public/app/plugins/datasource/elasticsearch/configuration/ElasticDetails.tsx @@ -1,8 +1,8 @@ import React from 'react'; import { EventsWithValidation, regexValidation, LegacyForms } from '@grafana/ui'; -const { Select, Input, FormField, Switch } = LegacyForms; +const { Select, Input, FormField } = LegacyForms; import { ElasticsearchOptions } from '../types'; -import { DataSourceSettings, onUpdateDatasourceJsonDataOptionChecked, SelectableValue } from '@grafana/data'; +import { DataSourceSettings, SelectableValue } from '@grafana/data'; const indexPatternTypes = [ { label: 'No pattern', value: 'none' }, @@ -144,29 +144,11 @@ export const ElasticDetails = (props: Props) => { /> - {value.jsonData.esVersion >= 70 && ( -