From 4d96afa979a1789ae7b2f2d90be245cba4ebe8ec Mon Sep 17 00:00:00 2001
From: Ivan Ortega Alba <ivanortegaalba@gmail.com>
Date: Thu, 27 Apr 2023 16:51:31 +0200
Subject: [PATCH] Check add DS permissions in advanced DS picker (#67237)

---
 .../datasources/components/picker/DataSourceModal.tsx        | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/public/app/features/datasources/components/picker/DataSourceModal.tsx b/public/app/features/datasources/components/picker/DataSourceModal.tsx
index 4c18c10b66a..5d101c5b4c0 100644
--- a/public/app/features/datasources/components/picker/DataSourceModal.tsx
+++ b/public/app/features/datasources/components/picker/DataSourceModal.tsx
@@ -16,9 +16,11 @@ import {
   Icon,
 } from '@grafana/ui';
 import { config } from 'app/core/config';
+import { contextSrv } from 'app/core/core';
 import { ROUTES as CONNECTIONS_ROUTES } from 'app/features/connections/constants';
 import * as DFImport from 'app/features/dataframe-import';
 import { DATASOURCES_ROUTES } from 'app/features/datasources/constants';
+import { AccessControlAction } from 'app/types';
 
 import { DataSourceList } from './DataSourceList';
 
@@ -51,6 +53,7 @@ export function DataSourceModal({
 }: DataSourceModalProps) {
   const styles = useStyles2(getDataSourceModalStyles);
   const [search, setSearch] = useState('');
+  const hasCreateRights = contextSrv.hasPermission(AccessControlAction.DataSourcesCreate);
   const analyticsInteractionSrc = reportedInteractionFrom || 'modal';
   const newDataSourceURL = config.featureToggles.dataConnectionsConsole
     ? CONNECTIONS_ROUTES.DataSourcesNew
@@ -147,6 +150,8 @@ export function DataSourceModal({
           <LinkButton
             variant="secondary"
             href={newDataSourceURL}
+            disabled={!hasCreateRights}
+            tooltip={!hasCreateRights ? 'You do not have permission to configure new data sources' : undefined}
             onClick={() => {
               reportInteraction(INTERACTION_EVENT_NAME, {
                 item: INTERACTION_ITEM.CONFIG_NEW_DS,