noImplicitAny: Sub 3000 errors (#17821)

* noImplicitAny Stackdriver

* Sub 3000 noImplicitAny

* Update error count limit

* Add DataQueryRequest type

public/app/plugins/datasource/stackdriver/components/Aggregations.test.tsx

@@ -7,6 +7,7 @@ import { TemplateSrvStub } from 'test/specs/helpers';
 
 const props: Props = {
   onChange: () => {},
+  // @ts-ignore
   templateSrv: new TemplateSrvStub(),
   metricDescriptor: {
     valueType: '',
@@ -18,7 +19,7 @@ const props: Props = {
 };
 
 describe('Aggregations', () => {
-  let wrapper;
+  let wrapper: any;
   it('renders correctly', () => {
     const tree = renderer.create(<Aggregations {...props} />).toJSON();
     expect(tree).toMatchSnapshot();
@@ -33,7 +34,7 @@ describe('Aggregations', () => {
       it('', () => {
         const options = wrapper.state().aggOptions[0].options;
         expect(options.length).toEqual(11);
-        expect(options.map(o => o.value)).toEqual(
+        expect(options.map((o: any) => o.value)).toEqual(
           expect.not.arrayContaining(['REDUCE_COUNT_TRUE', 'REDUCE_COUNT_FALSE'])
         );
       });
@@ -51,7 +52,7 @@ describe('Aggregations', () => {
         const options = wrapper.state().aggOptions[0].options;
 
         expect(options.length).toEqual(10);
-        expect(options.map(o => o.value)).toEqual(expect.arrayContaining(['REDUCE_NONE']));
+        expect(options.map((o: any) => o.value)).toEqual(expect.arrayContaining(['REDUCE_NONE']));
       });
     });
   });

public/app/plugins/datasource/stackdriver/components/Aggregations.tsx

@@ -7,7 +7,7 @@ import { TemplateSrv } from 'app/features/templating/template_srv';
 import { ValueTypes, MetricKind } from '../constants';
 
 export interface Props {
-  onChange: (metricDescriptor) => void;
+  onChange: (metricDescriptor: any) => void;
   templateSrv: TemplateSrv;
   metricDescriptor: {
     valueType: string;
@@ -38,7 +38,7 @@ export class Aggregations extends React.Component<Props, State> {
   }
 
   setAggOptions({ metricDescriptor }: Props) {
-    let aggOptions = [];
+    let aggOptions: any[] = [];
     if (metricDescriptor) {
       aggOptions = [
         {

public/app/plugins/datasource/stackdriver/components/AliasBy.tsx

@@ -3,7 +3,7 @@ import { debounce } from 'lodash';
 import { Input } from '@grafana/ui';
 
 export interface Props {
-  onChange: (alignmentPeriod) => void;
+  onChange: (alignmentPeriod: any) => void;
   value: string;
 }
 
@@ -12,9 +12,9 @@ export interface State {
 }
 
 export class AliasBy extends Component<Props, State> {
-  propagateOnChange: (value) => void;
+  propagateOnChange: (value: any) => void;
 
-  constructor(props) {
+  constructor(props: Props) {
     super(props);
     this.propagateOnChange = debounce(this.props.onChange, 500);
     this.state = { value: '' };
@@ -30,7 +30,7 @@ export class AliasBy extends Component<Props, State> {
     }
   }
 
-  onChange = e => {
+  onChange = (e: any) => {
     this.setState({ value: e.target.value });
     this.propagateOnChange(e.target.value);
   };

public/app/plugins/datasource/stackdriver/components/AlignmentPeriods.tsx

@@ -7,7 +7,7 @@ import { alignmentPeriods, alignOptions } from '../constants';
 import { TemplateSrv } from 'app/features/templating/template_srv';
 
 export interface Props {
-  onChange: (alignmentPeriod) => void;
+  onChange: (alignmentPeriod: any) => void;
   templateSrv: TemplateSrv;
   alignmentPeriod: string;
   perSeriesAligner: string;

public/app/plugins/datasource/stackdriver/components/Alignments.tsx

@@ -6,7 +6,7 @@ import { TemplateSrv } from 'app/features/templating/template_srv';
 import { SelectOptionItem } from '@grafana/ui';
 
 export interface Props {
-  onChange: (perSeriesAligner) => void;
+  onChange: (perSeriesAligner: any) => void;
   templateSrv: TemplateSrv;
   alignOptions: Array<SelectOptionItem<string>>;
   perSeriesAligner: string;

public/app/plugins/datasource/stackdriver/components/AnnotationQueryEditor.tsx

@@ -6,7 +6,7 @@ import { TemplateSrv } from 'app/features/templating/template_srv';
 import StackdriverDatasource from '../datasource';
 import { Metrics } from './Metrics';
 import { Filter } from './Filter';
-import { AnnotationTarget } from '../types';
+import { AnnotationTarget, MetricDescriptor } from '../types';
 import { AnnotationsHelp } from './AnnotationsHelp';
 
 export interface Props {
@@ -40,7 +40,7 @@ export class AnnotationQueryEditor extends React.Component<Props, State> {
     });
   }
 
-  onMetricTypeChange = ({ valueType, metricKind, type, unit }) => {
+  onMetricTypeChange = ({ valueType, metricKind, type, unit }: MetricDescriptor) => {
     const { onQueryChange } = this.props;
     this.setState(
       {
@@ -55,7 +55,7 @@ export class AnnotationQueryEditor extends React.Component<Props, State> {
     );
   };
 
-  onChange(prop, value) {
+  onChange(prop: string, value: string | string[]) {
     this.setState({ [prop]: value }, () => {
       this.props.onQueryChange(this.state);
     });

public/app/plugins/datasource/stackdriver/components/Filter.tsx

@@ -25,7 +25,7 @@ interface State {
   loading: Promise<any>;
 }
 
-const labelData = {
+const labelData: any = {
   metricLabels: {},
   resourceLabels: {},
   resourceTypes: [],
@@ -43,15 +43,15 @@ export class Filter extends React.Component<Props, State> {
     const { groupBys, filters, hideGroupBys } = this.props;
     const loader = getAngularLoader();
 
-    const filtersChanged = filters => {
+    const filtersChanged = (filters: string[]) => {
       this.props.filtersChanged(filters);
     };
 
-    const groupBysChanged = groupBys => {
+    const groupBysChanged = (groupBys: string[]) => {
       this.props.groupBysChanged(groupBys);
     };
 
-    const scopeProps = {
+    const scopeProps: any = {
       loading: null,
       labelData,
       groupBys,
@@ -91,7 +91,7 @@ export class Filter extends React.Component<Props, State> {
     }
   }
 
-  async loadLabels(scope) {
+  async loadLabels(scope: any) {
     return new Promise(async resolve => {
       try {
         if (!this.props.metricType) {

public/app/plugins/datasource/stackdriver/components/Help.tsx

@@ -1,11 +1,13 @@
 import React from 'react';
 import { Project } from './Project';
 import StackdriverDatasource from '../datasource';
+import { MetricDescriptor } from '../types';
 
 export interface Props {
   datasource: StackdriverDatasource;
   rawQuery: string;
   lastQueryError: string;
+  metricDescriptor?: MetricDescriptor;
 }
 
 interface State {
@@ -27,7 +29,7 @@ export class Help extends React.Component<Props, State> {
     this.setState({ displaRawQuery: !this.state.displaRawQuery });
   };
 
-  shouldComponentUpdate(nextProps) {
+  shouldComponentUpdate(nextProps: Props) {
     return nextProps.metricDescriptor !== null;
   }
 

public/app/plugins/datasource/stackdriver/components/Metrics.tsx

@@ -37,7 +37,7 @@ export class Metrics extends React.Component<Props, State> {
     defaultProject: '',
   };
 
-  constructor(props) {
+  constructor(props: Props) {
     super(props);
   }
 
@@ -83,7 +83,7 @@ export class Metrics extends React.Component<Props, State> {
     this.setState({ metricDescriptors, services, metrics, service: service, metricDescriptor });
   }
 
-  getSelectedMetricDescriptor(metricType) {
+  getSelectedMetricDescriptor(metricType: string) {
     return this.state.metricDescriptors.find(md => md.type === this.props.templateSrv.replace(metricType));
   }
 
@@ -103,7 +103,7 @@ export class Metrics extends React.Component<Props, State> {
     return metricsByService;
   }
 
-  onServiceChange = service => {
+  onServiceChange = (service: any) => {
     const { metricDescriptors } = this.state;
     const { templateSrv, metricType } = this.props;
 
@@ -123,7 +123,7 @@ export class Metrics extends React.Component<Props, State> {
     }
   };
 
-  onMetricTypeChange = value => {
+  onMetricTypeChange = (value: any) => {
     const metricDescriptor = this.getSelectedMetricDescriptor(value);
     this.setState({ metricDescriptor });
     this.props.onChange({ ...metricDescriptor, type: value });