From 4ec03bad64ffb618a6baa5253f50fa833ab45378 Mon Sep 17 00:00:00 2001 From: Dominik Prokop Date: Thu, 1 Sep 2022 05:42:06 -0700 Subject: [PATCH] Revert 54400 (#54570) * Revert "Add FocusScope to PanelEditor when open in the Dashboard Page so that a11y focus never catches invisible content. (#54400)" This reverts commit ef3205050804a746dffc19d1fbb792fe1177c6d8. * Betterer <3 --- .betterer.results | 16 ++++++++++++++-- .../dashboard/containers/DashboardPage.tsx | 9 +-------- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/.betterer.results b/.betterer.results index 4cf22bb8bcc..661a7ff0fde 100644 --- a/.betterer.results +++ b/.betterer.results @@ -7921,10 +7921,22 @@ exports[`better eslint`] = { [0, 0, 0, "Unexpected any. Specify a different type.", "9"], [0, 0, 0, "Unexpected any. Specify a different type.", "10"], [0, 0, 0, "Unexpected any. Specify a different type.", "11"], - [0, 0, 0, "Unexpected any. Specify a different type.", "12"] + [0, 0, 0, "Unexpected any. Specify a different type.", "12"], + [0, 0, 0, "Unexpected any. Specify a different type.", "13"], + [0, 0, 0, "Unexpected any. Specify a different type.", "14"], + [0, 0, 0, "Unexpected any. Specify a different type.", "15"], + [0, 0, 0, "Unexpected any. Specify a different type.", "16"], + [0, 0, 0, "Unexpected any. Specify a different type.", "17"], + [0, 0, 0, "Unexpected any. Specify a different type.", "18"], + [0, 0, 0, "Unexpected any. Specify a different type.", "19"], + [0, 0, 0, "Unexpected any. Specify a different type.", "20"] ], "public/app/plugins/datasource/tempo/traceql/autocomplete.ts:5381": [ - [0, 0, 0, "Do not use any type assertions.", "0"] + [0, 0, 0, "Do not use any type assertions.", "0"], + [0, 0, 0, "Do not use any type assertions.", "1"], + [0, 0, 0, "Do not use any type assertions.", "2"], + [0, 0, 0, "Do not use any type assertions.", "3"], + [0, 0, 0, "Do not use any type assertions.", "4"] ], "public/app/plugins/datasource/testdata/ConfigEditor.tsx:5381": [ [0, 0, 0, "Unexpected any. Specify a different type.", "0"] diff --git a/public/app/features/dashboard/containers/DashboardPage.tsx b/public/app/features/dashboard/containers/DashboardPage.tsx index bfffbfc5183..d2b273d3968 100644 --- a/public/app/features/dashboard/containers/DashboardPage.tsx +++ b/public/app/features/dashboard/containers/DashboardPage.tsx @@ -1,5 +1,4 @@ import { cx } from '@emotion/css'; -import { FocusScope } from '@react-aria/focus'; import React, { PureComponent } from 'react'; import { connect, ConnectedProps } from 'react-redux'; @@ -372,13 +371,7 @@ export class UnthemedDashboardPage extends PureComponent { {inspectPanel && } - {editPanel && ( - -
- -
-
- )} + {editPanel && } {queryParams.editview && (