IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

InfluxDB: Fix parsing empty response (#77353)

Browse Source 
Fix parsing empty response
This commit is contained in:
ismail simsek 2023-10-30 11:39:15 +01:00 committed by GitHub
parent 8d2b3f973e
commit 4ed36cbc1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/tsdb/influxdb/influxql/response_parser.go
View File

@ -83,6 +83,10 @@ func transformRows(rows []models.Row, query models.Query) data.Frames {
}
}
if len(rows) == 0 {
return make([]*data.Frame, 0)
}
// Preallocate for the worst-case scenario
frames := make([]*data.Frame, 0, len(rows)*len(rows[0].Columns))

19
pkg/tsdb/influxdb/influxql/response_parser_test.go
View File

@ -407,6 +407,7 @@ func TestInfluxdbResponseParser(t *testing.T) {
)
testFrame.Meta = &data.FrameMeta{PreferredVisualization: graphVisType, ExecutedQueryString: "Test raw query"}
result := ResponseParse(prepare(response), 200, generateQuery(query))
t.Run("should parse aliases", func(t *testing.T) {
if diff := cmp.Diff(testFrame, result.Frames[0], data.FrameTestCompareOptions()...); diff != "" {
t.Errorf("Result mismatch (-want +got):\n%s", diff)
@ -575,6 +576,7 @@ func TestInfluxdbResponseParser(t *testing.T) {
t.Errorf("Result mismatch (-want +got):\n%s", diff)
}
})
t.Run("shouldn't parse aliases", func(t *testing.T) {
query = models.Query{Alias: "alias words with no brackets"}
result = ResponseParse(prepare(response), 200, generateQuery(query))
@ -681,6 +683,23 @@ func TestInfluxdbResponseParser(t *testing.T) {
_, err := parseTimestamp("hello")
require.Error(t, err)
})
t.Run("InfluxDB returns empty DataResponse when there is empty response", func(t *testing.T) {
response := `
{
"results": [
{
"statement_id": 0
}
]
}
`
query := models.Query{}
result := ResponseParse(prepare(response), 200, generateQuery(query))
assert.NotNil(t, result.Frames)
assert.Equal(t, 0, len(result.Frames))
})
}
func TestResponseParser_Parse_RetentionPolicy(t *testing.T) {