From 4f899e3576abe8d0c72b0a1c828f9ceb114fe1d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1bor=20Farkas?= Date: Tue, 28 Nov 2023 12:46:01 +0100 Subject: [PATCH] sql: removed dependency on test-db-check (#78717) --- .../grafana-postgresql-datasource/postgres_test.go | 12 ++++++++++-- pkg/tsdb/mysql/mysql_test.go | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/pkg/tsdb/grafana-postgresql-datasource/postgres_test.go b/pkg/tsdb/grafana-postgresql-datasource/postgres_test.go index 553ec51a254..01b89f9d17c 100644 --- a/pkg/tsdb/grafana-postgresql-datasource/postgres_test.go +++ b/pkg/tsdb/grafana-postgresql-datasource/postgres_test.go @@ -4,6 +4,7 @@ import ( "context" "fmt" "math/rand" + "os" "strings" "testing" "time" @@ -14,7 +15,6 @@ import ( "github.com/stretchr/testify/require" "xorm.io/xorm" - "github.com/grafana/grafana/pkg/infra/db" "github.com/grafana/grafana/pkg/services/sqlstore/sqlutil" "github.com/grafana/grafana/pkg/setting" "github.com/grafana/grafana/pkg/tsdb/sqleng" @@ -180,7 +180,7 @@ func TestIntegrationPostgres(t *testing.T) { // change to true to run the PostgreSQL tests const runPostgresTests = false - if !(db.IsTestDbPostgres() || runPostgresTests) { + if !(isTestDbPostgres() || runPostgresTests) { t.Skip() } @@ -1427,3 +1427,11 @@ type tlsTestManager struct { func (m *tlsTestManager) getTLSSettings(dsInfo sqleng.DataSourceInfo) (tlsSettings, error) { return m.settings, nil } + +func isTestDbPostgres() bool { + if db, present := os.LookupEnv("GRAFANA_TEST_DB"); present { + return db == "postgres" + } + + return false +} diff --git a/pkg/tsdb/mysql/mysql_test.go b/pkg/tsdb/mysql/mysql_test.go index a30152bbc10..8e776ac0672 100644 --- a/pkg/tsdb/mysql/mysql_test.go +++ b/pkg/tsdb/mysql/mysql_test.go @@ -4,6 +4,7 @@ import ( "context" "fmt" "math/rand" + "os" "strings" "testing" "time" @@ -13,7 +14,6 @@ import ( "github.com/stretchr/testify/require" "xorm.io/xorm" - "github.com/grafana/grafana/pkg/infra/db" "github.com/grafana/grafana/pkg/services/sqlstore/sqlutil" "github.com/grafana/grafana/pkg/setting" "github.com/grafana/grafana/pkg/tsdb/sqleng" @@ -35,7 +35,7 @@ func TestIntegrationMySQL(t *testing.T) { runMySQLTests := false // runMySqlTests := true - if !(db.IsTestDbMySQL() || runMySQLTests) { + if !(isTestDbMySQL() || runMySQLTests) { t.Skip() } @@ -1321,3 +1321,11 @@ func genTimeRangeByInterval(from time.Time, duration time.Duration, interval tim return timeRange } + +func isTestDbMySQL() bool { + if db, present := os.LookupEnv("GRAFANA_TEST_DB"); present { + return db == "mysql" + } + + return false +}