From 4fdca3873cd656fe3df14ba7a7a7df9e38edf59a Mon Sep 17 00:00:00 2001 From: Sofia Papagiannaki Date: Wed, 23 Sep 2020 14:13:54 +0300 Subject: [PATCH] Revert "Alerting: remove spammy error" This reverts commit 7ee84269a8df40c1484affa3347d743f0a773273. --- pkg/services/alerting/rule.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/services/alerting/rule.go b/pkg/services/alerting/rule.go index ff8d1bdce28..5edd3467c55 100644 --- a/pkg/services/alerting/rule.go +++ b/pkg/services/alerting/rule.go @@ -139,8 +139,9 @@ func NewRuleFromDBAlert(ruleDef *models.Alert) (*Rule, error) { jsonModel := simplejson.NewFromAny(v) if id, err := jsonModel.Get("id").Int64(); err == nil { uid, err := translateNotificationIDToUID(id, ruleDef.OrgId) - // err != nil in the most cases means that the notifier is obsolete - if err == nil { + if err != nil { + logger.Error("Unable to translate notification id to uid", "error", err.Error(), "dashboardId", model.DashboardID, "alertId", model.ID, "panelId", model.PanelID, "notificationId", id) + } else { model.Notifications = append(model.Notifications, uid) } } else if uid, err := jsonModel.Get("uid").String(); err == nil {