Refactor: consistant plugin/meta usage (#16834)

This commit is contained in:
Ryan McKinley
2019-04-30 22:36:46 -07:00
committed by GitHub
parent fe20dde5db
commit 51a98565dc
16 changed files with 162 additions and 155 deletions

View File

@@ -1,6 +1,5 @@
import { PanelModel } from './PanelModel';
import { getPanelPlugin } from '../../plugins/__mocks__/pluginMocks';
import { PanelPlugin, AngularPanelPlugin } from '@grafana/ui/src/types/panel';
class TablePanelCtrl {}
@@ -31,10 +30,13 @@ describe('PanelModel', () => {
};
model = new PanelModel(modelJson);
model.pluginLoaded(
getPanelPlugin({
id: 'table',
angularPlugin: new AngularPanelPlugin(TablePanelCtrl),
})
getPanelPlugin(
{
id: 'table',
},
null, // react
TablePanelCtrl // angular
)
);
});
@@ -123,15 +125,10 @@ describe('PanelModel', () => {
describe('when changing to react panel', () => {
const onPanelTypeChanged = jest.fn();
const reactPlugin = new PanelPlugin({} as any).setPanelChangeHandler(onPanelTypeChanged as any);
const reactPlugin = getPanelPlugin({ id: 'react' }).setPanelChangeHandler(onPanelTypeChanged as any);
beforeEach(() => {
model.changePlugin(
getPanelPlugin({
id: 'react',
panelPlugin: reactPlugin,
})
);
model.changePlugin(reactPlugin);
});
it('should call react onPanelTypeChanged', () => {