IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Panel inspect: Fix inspect keyboard shortcut when grafana served from subpath (#99366)

Browse Source 
* Panel inspect: Fix inspect keyboard shortcut when grafana served from a subpath

* Add e2e test
This commit is contained in:
Dominik Prokop 2025-01-22 13:25:10 +01:00 committed by GitHub
parent 5b8e6f8fa8
commit 51b4ac50aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
e2e/dashboards-suite/dashboard-keybindings.spec.ts
View File

@ -21,4 +21,12 @@ describe('Dashboard keybindings', () => {
e2e.components.Panels.Panel.title('server = A, pod = Bob').should('be.visible');
e2e.components.Panels.Panel.title('server = B, pod = Bob').should('be.visible');
});
it('should open panel inspect', () => {
e2e.flows.openDashboard({ uid: 'edediimbjhdz4b/a-tall-dashboard' });
e2e.components.Panels.Panel.title('Panel #1').type('i');
e2e.components.PanelInspector.Json.content().should('be.visible');
cy.get('body').type('{esc}');
e2e.components.PanelInspector.Json.content().should('not.exist');
});
});

2
public/app/features/dashboard-scene/scene/keyboardShortcuts.ts
View File

@ -105,7 +105,7 @@ export function setupKeyboardShortcuts(scene: DashboardScene) {
keybindings.addBinding({
key: 'i',
onTrigger: withFocusedPanel(scene, async (vizPanel: VizPanel) => {
locationService.push(getInspectUrl(vizPanel));
locationService.push(locationUtil.stripBaseFromUrl(getInspectUrl(vizPanel)));
}),
});