Navigation: Stop clearing search state when opening a result in a new tab (#58880)

search: only clear search state if not opening in a new tab
This commit is contained in:
Ashley Harrison 2022-11-18 14:17:59 +00:00 committed by GitHub
parent 0bf3c98eec
commit 5226a61f67
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -220,10 +220,11 @@ export class SearchStateManager extends StateManagerBase<SearchState> {
/**
* When item is selected clear some filters and report interaction
*/
onSearchItemClicked = () => {
// Clear some filters
this.setState({ tag: [], starred: false, sort: null, query: '', folderUid: undefined });
this.onCloseSearch();
onSearchItemClicked = (e: React.MouseEvent<HTMLElement>) => {
// Clear some filters only if we're not opening a search item in a new tab
if (!e.altKey && !e.ctrlKey && !e.metaKey) {
this.setState({ tag: [], starred: false, sort: null, query: '', folderUid: undefined });
}
reportSearchResultInteraction(this.state.eventTrackingNamespace, {
layout: this.state.layout,