IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

VizTooltip: Check useragent to perform consistently on all mobile devices (#99655)

Browse Source 
* Add useragent check to be comprehensive

* move check outside function and add hopefully clarifying comment
This commit is contained in:
Kristina 2025-01-28 08:00:15 -06:00 committed by GitHub
parent 0bf31c14a7
commit 52a6c27d99
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/grafana-ui/src/components/uPlot/plugins/TooltipPlugin2.tsx
View File

@ -108,6 +108,8 @@ const maybeZoomAction = (e?: MouseEvent | null) => e != null && !e.ctrlKey && !e
const getDataLinksFallback: GetDataLinksCallback = () => []; const getDataLinksFallback: GetDataLinksCallback = () => [];
const userAgentIsMobile = /Android|iPhone|iPad/i.test(navigator.userAgent);
/** /**
* @alpha * @alpha
*/ */
@ -666,8 +668,9 @@ export const TooltipPlugin2 = ({
// if not viaSync, re-dispatch real event // if not viaSync, re-dispatch real event
if (event != null) { if (event != null) {
// we expect to re-dispatch mousemove, but on mobile we'll get mouseup or click // we expect to re-dispatch mousemove, but may have a different event type, so create a mousemove event and fire that instead
const isMobile = event.type !== 'mousemove'; // this doesn't work for every mobile device, so fall back to checking the useragent as well
const isMobile = event.type !== 'mousemove' || userAgentIsMobile;
if (isMobile) { if (isMobile) {
event = new MouseEvent('mousemove', { event = new MouseEvent('mousemove', {