Chore: Improve some types (#64675)

* some type fixes

* few more

* more type fixes

* fix the majority of (window as any) calls

* don't make new variable for event

* few more

* MOAR

packages/grafana-data/src/field/fieldOverrides.test.ts

@@ -640,7 +640,7 @@ describe('getLinksSupplier', () => {
               },
             ],
           },
-          display: (v) => ({ numeric: v, text: String(v) }),
+          display: (v) => ({ numeric: Number(v), text: String(v) }),
         },
       ],
     });

packages/grafana-data/src/types/displayValue.ts

@@ -1,6 +1,6 @@
 import { FormattedValue } from '../valueFormats';
 
-export type DisplayProcessor = (value: any, decimals?: DecimalCount) => DisplayValue;
+export type DisplayProcessor = (value: unknown, decimals?: DecimalCount) => DisplayValue;
 
 export interface DisplayValue extends FormattedValue {
   /**

packages/grafana-data/src/utils/Registry.ts

@@ -87,10 +87,10 @@ export class Registry<T extends RegistryItem> {
       this.initialize();
     }
 
-    const select = {
+    const select: RegistrySelectInfo = {
       options: [],
       current: [],
-    } as RegistrySelectInfo;
+    };
 
     const currentOptions: Record<string, SelectableValue<string>> = {};
     if (current) {

packages/grafana-data/src/utils/csv.ts

@@ -34,7 +34,7 @@ export interface CSVParseCallbacks {
   onHeader: (fields: Field[]) => void;
 
   // Called after each row is read
-  onRow: (row: any[]) => void;
+  onRow: (row: string[]) => void;
 }
 
 export interface CSVOptions {
@@ -73,9 +73,9 @@ export class CSVReader {
   }
 
   // PapaParse callback on each line
-  private chunk = (results: ParseResult<any>, parser: Parser): void => {
+  private chunk = (results: ParseResult<string[]>, parser: Parser): void => {
     for (let i = 0; i < results.data.length; i++) {
-      const line: string[] = results.data[i];
+      const line = results.data[i];
       if (line.length < 1) {
         continue;
       }
@@ -191,15 +191,18 @@ export class CSVReader {
   }
 }
 
-type FieldWriter = (value: any) => string;
+type FieldWriter = (value: unknown) => string;
 
-function writeValue(value: any, config: CSVConfig): string {
+function writeValue(value: unknown, config: CSVConfig): string {
+  if (value === null || value === undefined) {
+    return '';
+  }
   const str = value.toString();
   if (str.includes('"')) {
     // Escape the double quote characters
     return config.quoteChar + str.replace(/"/gi, '""') + config.quoteChar;
   }
-  if (str.includes('\n') || str.includes(config.delimiter)) {
+  if (str.includes('\n') || (config.delimiter && str.includes(config.delimiter))) {
     return config.quoteChar + str + config.quoteChar;
   }
   return str;
@@ -207,13 +210,13 @@ function writeValue(value: any, config: CSVConfig): string {
 
 function makeFieldWriter(field: Field, config: CSVConfig): FieldWriter {
   if (field.display) {
-    return (value: any) => {
+    return (value: unknown) => {
       const displayValue = field.display!(value);
       return writeValue(formattedValueToString(displayValue), config);
     };
   }
 
-  return (value: any) => writeValue(value, config);
+  return (value: unknown) => writeValue(value, config);
 }
 
 function getHeaderLine(key: string, fields: Field[], config: CSVConfig): string {
@@ -229,7 +232,7 @@ function getHeaderLine(key: string, fields: Field[], config: CSVConfig): string
           line = line + config.delimiter;
         }
 
-        let v: any = fields[i].name;
+        let v = fields[i].name;
         if (isType) {
           v = fields[i].type;
         } else if (isName) {

packages/grafana-data/src/utils/fieldParser.ts

@@ -1,7 +1,7 @@
 import { guessFieldTypeFromValue } from '../dataframe/processDataFrame';
 import { Field, FieldType } from '../types/dataFrame';
 
-export function makeFieldParser(value: any, field: Field): (value: string) => any {
+export function makeFieldParser(value: unknown, field: Field): (value: string) => any {
   if (!field.type) {
     if (field.name === 'time' || field.name === 'Time') {
       field.type = FieldType.time;

packages/grafana-data/src/utils/labels.ts

@@ -23,14 +23,11 @@ export function parseLabels(labels: string): Labels {
  * Returns a map labels that are common to the given label sets.
  */
 export function findCommonLabels(labelsSets: Labels[]): Labels {
-  return labelsSets.reduce((acc, labels) => {
-    if (!labels) {
-      throw new Error('Need parsed labels to find common labels.');
-    }
-    if (!acc) {
-      // Initial set
-      acc = { ...labels };
-    } else {
+  return labelsSets.reduce(
+    (acc, labels) => {
+      if (!labels) {
+        throw new Error('Need parsed labels to find common labels.');
+      }
       // Remove incoming labels that are missing or not matching in value
       Object.keys(labels).forEach((key) => {
         if (acc[key] === undefined || acc[key] !== labels[key]) {
@@ -43,9 +40,10 @@ export function findCommonLabels(labelsSets: Labels[]): Labels {
           delete acc[key];
         }
       });
-    }
-    return acc;
-  }, undefined as unknown as Labels);
+      return acc;
+    },
+    { ...labelsSets[0] }
+  );
 }
 
 /**

packages/grafana-data/src/utils/logs.ts

@@ -30,7 +30,7 @@ export function getLogLevel(line: string): LogLevel {
 
     if (result) {
       if (currentIndex === undefined || result.index < currentIndex) {
-        level = (LogLevel as any)[key];
+        level = LogLevel[key as keyof typeof LogLevel];
         currentIndex = result.index;
       }
     }
@@ -40,7 +40,7 @@ export function getLogLevel(line: string): LogLevel {
 
 /** @deprecated will be removed in the next major version */
 export function getLogLevelFromKey(key: string | number): LogLevel {
-  const level = (LogLevel as any)[key.toString().toLowerCase()];
+  const level = LogLevel[key.toString().toLowerCase() as keyof typeof LogLevel];
   if (level) {
     return level;
   }
@@ -136,7 +136,7 @@ export function calculateLogsLabelStats(rows: LogRowModel[], label: string): Log
   const rowCount = rowsWithLabel.length;
 
   // Get label value counts for eligible rows
-  const countsByValue = countBy(rowsWithLabel, (row) => (row as LogRowModel).labels[label]);
+  const countsByValue = countBy(rowsWithLabel, (row) => row.labels[label]);
   return getSortedCounts(countsByValue, rowCount);
 }
 

packages/grafana-data/src/utils/makeClassES5Compatible.ts

@@ -2,8 +2,10 @@
  * @beta
  * Proxies a ES6 class so that it can be used as a base class for an ES5 class
  */
-export function makeClassES5Compatible<T>(ES6Class: T): T {
-  return new Proxy(ES6Class as any, {
+export function makeClassES5Compatible<T extends abstract new (...args: ConstructorParameters<T>) => InstanceType<T>>(
+  ES6Class: T
+): T {
+  return new Proxy(ES6Class, {
     // ES5 code will call it like a function using super
     apply(target, self, argumentsList) {
       if (typeof Reflect === 'undefined' || !Reflect.construct) {
@@ -12,5 +14,5 @@ export function makeClassES5Compatible<T>(ES6Class: T): T {
 
       return Reflect.construct(target, argumentsList, self.constructor);
     },
-  }) as unknown as T;
+  });
 }

packages/grafana-data/src/utils/tests/mockTransformationsRegistry.ts

@@ -1,7 +1,7 @@
 import { standardTransformersRegistry } from '../../transformations';
 import { DataTransformerInfo } from '../../types';
 
-export const mockTransformationsRegistry = (transformers: Array<DataTransformerInfo<any>>) => {
+export const mockTransformationsRegistry = (transformers: DataTransformerInfo[]) => {
   standardTransformersRegistry.setInit(() => {
     return transformers.map((t) => {
       return {

packages/grafana-data/src/valueFormats/arithmeticFormatters.ts

@@ -42,5 +42,5 @@ export function sci(value: number | null, decimals: DecimalCount): FormattedValu
   if (value == null) {
     return { text: '' };
   }
-  return { text: value.toExponential(decimals as number) };
+  return { text: value.toExponential(decimals ?? undefined) };
 }

packages/grafana-data/src/valueFormats/dateTimeFormatters.ts

@@ -228,7 +228,7 @@ export function toDuration(size: number, decimals: DecimalCount, timeScale: Inte
   let decimalsCount = 0;
 
   if (decimals !== null && decimals !== undefined) {
-    decimalsCount = decimals as number;
+    decimalsCount = decimals;
   }
 
   for (let i = 0; i < UNITS.length && decimalsCount >= 0; i++) {

packages/grafana-data/src/valueFormats/valueFormats.ts

@@ -127,7 +127,7 @@ export function isBooleanUnit(unit?: string) {
 }
 
 export function booleanValueFormatter(t: string, f: string): ValueFormatter {
-  return (value: any) => {
+  return (value) => {
     return { text: value ? t : f };
   };
 }
@@ -159,7 +159,7 @@ export function locale(value: number, decimals: DecimalCount): FormattedValue {
     return { text: '' };
   }
   return {
-    text: value.toLocaleString(undefined, { maximumFractionDigits: decimals as number }),
+    text: value.toLocaleString(undefined, { maximumFractionDigits: decimals ?? undefined }),
   };
 }
 

packages/grafana-data/test/__mocks__/pluginMocks.ts

@@ -34,7 +34,7 @@ export const getMockPlugins = (amount: number): PluginMeta[] => {
     });
   }
 
-  return plugins as any;
+  return plugins;
 };
 
 export function getPanelPlugin(