diff --git a/.betterer.results b/.betterer.results index 7850ddb5005..bb566f91425 100644 --- a/.betterer.results +++ b/.betterer.results @@ -656,9 +656,6 @@ exports[`better eslint`] = { [0, 0, 0, "Unexpected any. Specify a different type.", "2"], [0, 0, 0, "Unexpected any. Specify a different type.", "3"] ], - "packages/grafana-ui/src/components/PageLayout/PageToolbar.tsx:5381": [ - [0, 0, 0, "Use data-testid for E2E selectors instead of aria-label", "0"] - ], "packages/grafana-ui/src/components/PanelChrome/LoadingIndicator.tsx:5381": [ [0, 0, 0, "Use data-testid for E2E selectors instead of aria-label", "0"] ], diff --git a/packages/grafana-e2e-selectors/src/selectors/components.ts b/packages/grafana-e2e-selectors/src/selectors/components.ts index 6819076b2d5..78182274957 100644 --- a/packages/grafana-e2e-selectors/src/selectors/components.ts +++ b/packages/grafana-e2e-selectors/src/selectors/components.ts @@ -287,7 +287,7 @@ export const Components = { button: (title: string) => `QueryEditor toolbar item button ${title}`, }, BackButton: { - backArrow: 'Go Back', + backArrow: 'data-testid Go Back', }, OptionsGroup: { group: (title?: string) => (title ? `Options group ${title}` : 'Options group'), diff --git a/packages/grafana-ui/src/components/PageLayout/PageToolbar.tsx b/packages/grafana-ui/src/components/PageLayout/PageToolbar.tsx index c7d70c49188..3d9e7605750 100644 --- a/packages/grafana-ui/src/components/PageLayout/PageToolbar.tsx +++ b/packages/grafana-ui/src/components/PageLayout/PageToolbar.tsx @@ -92,7 +92,7 @@ export const PageToolbar = React.memo( tooltip="Go back (Esc)" tooltipPlacement="bottom" size="xxl" - aria-label={selectors.components.BackButton.backArrow} + data-testid={selectors.components.BackButton.backArrow} onClick={onGoBack} />