FlameGraph: Remove flameGraphItemCollapsing feature toggle (#90190)

Remove feature toggle
This commit is contained in:
Joey 2024-07-15 13:45:41 +01:00 committed by GitHub
parent 29ac7fd3c4
commit 5beaae8561
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 2 additions and 17 deletions

View File

@ -165,7 +165,6 @@ Experimental features might be changed or removed without prior notice.
| `dashboardSceneForViewers` | Enables dashboard rendering using Scenes for viewer roles |
| `dashboardSceneSolo` | Enables rendering dashboards using scenes for solo panels |
| `dashboardScene` | Enables dashboard rendering using scenes for all roles |
| `flameGraphItemCollapsing` | Allow collapsing of flame graph items |
| `pluginsSkipHostEnvVars` | Disables passing host environment variable to plugin processes |
| `tableSharedCrosshair` | Enables shared crosshair in table panel |
| `kubernetesFeatureToggles` | Use the kubernetes API for feature toggle management in the frontend |

View File

@ -142,7 +142,6 @@ export interface FeatureToggles {
ssoSettingsApi?: boolean;
canvasPanelPanZoom?: boolean;
logsInfiniteScrolling?: boolean;
flameGraphItemCollapsing?: boolean;
exploreMetrics?: boolean;
alertingSimplifiedRouting?: boolean;
logRowsPopoverMenu?: boolean;

View File

@ -929,13 +929,6 @@ var (
FrontendOnly: true,
Owner: grafanaObservabilityLogsSquad,
},
{
Name: "flameGraphItemCollapsing",
Description: "Allow collapsing of flame graph items",
Stage: FeatureStageExperimental,
FrontendOnly: true,
Owner: grafanaObservabilityTracesAndProfilingSquad,
},
{
Name: "exploreMetrics",
Description: "Enables the new Explore Metrics core app",

View File

@ -123,7 +123,6 @@ pdfTables,preview,@grafana/sharing-squad,false,false,false
ssoSettingsApi,GA,@grafana/identity-access-team,false,false,false
canvasPanelPanZoom,preview,@grafana/dataviz-squad,false,false,true
logsInfiniteScrolling,GA,@grafana/observability-logs,false,false,true
flameGraphItemCollapsing,experimental,@grafana/observability-traces-and-profiling,false,false,true
exploreMetrics,GA,@grafana/dashboards-squad,false,false,true
alertingSimplifiedRouting,GA,@grafana/alerting-squad,false,false,false
logRowsPopoverMenu,GA,@grafana/observability-logs,false,false,true

1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
123 ssoSettingsApi GA @grafana/identity-access-team false false false
124 canvasPanelPanZoom preview @grafana/dataviz-squad false false true
125 logsInfiniteScrolling GA @grafana/observability-logs false false true
flameGraphItemCollapsing experimental @grafana/observability-traces-and-profiling false false true
126 exploreMetrics GA @grafana/dashboards-squad false false true
127 alertingSimplifiedRouting GA @grafana/alerting-squad false false false
128 logRowsPopoverMenu GA @grafana/observability-logs false false true

View File

@ -503,10 +503,6 @@ const (
// Enables infinite scrolling for the Logs panel in Explore and Dashboards
FlagLogsInfiniteScrolling = "logsInfiniteScrolling"
// FlagFlameGraphItemCollapsing
// Allow collapsing of flame graph items
FlagFlameGraphItemCollapsing = "flameGraphItemCollapsing"
// FlagExploreMetrics
// Enables the new Explore Metrics core app
FlagExploreMetrics = "exploreMetrics"

View File

@ -1126,7 +1126,8 @@
"metadata": {
"name": "flameGraphItemCollapsing",
"resourceVersion": "1718727528075",
"creationTimestamp": "2023-11-09T14:31:07Z"
"creationTimestamp": "2023-11-09T14:31:07Z",
"deletionTimestamp": "2024-07-08T14:17:01Z"
},
"spec": {
"description": "Allow collapsing of flame graph items",

View File

@ -30,7 +30,6 @@ export const FlameGraphExploreContainer = (props: Props) => {
onViewSelected={(view: string) => interaction('view_selected', { view })}
onTextAlignSelected={(align: string) => interaction('text_align_selected', { align })}
onTableSort={(sort: string) => interaction('table_sort_selected', { sort })}
disableCollapsing={!config.featureToggles.flameGraphItemCollapsing}
/>
</div>
);

View File

@ -28,7 +28,6 @@ export const FlameGraphPanel = (props: PanelProps) => {
onViewSelected={(view: string) => interaction('view_selected', { view })}
onTextAlignSelected={(align: string) => interaction('text_align_selected', { align })}
onTableSort={(sort: string) => interaction('table_sort_selected', { sort })}
disableCollapsing={!config.featureToggles.flameGraphItemCollapsing}
/>
);
};