IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Slug: Use urlencoding to support non-ASCII characters (#70691)

Browse Source
This commit is contained in:
Emil Tullstedt
2023-07-10 21:05:39 +02:00
committed by GitHub
parent d358bce562
commit 5c19272065
4 changed files with 58 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/services/accesscontrol/models_test.go
View File

@@ -63,7 +63,7 @@ func TestSaveExternalServiceRoleCommand_Validate(t *testing.T) {
Permissions: []Permission{{Action: "users:read", Scope: "users:id:1"}},
},
wantErr: false,
wantID: "thisis-a-very-strange-app-name",
wantID: "thisis-a-very-strange-___-app-name",
},
{
name: "invalid empty Action",

6
pkg/services/dashboards/models_test.go
View File

@@ -77,9 +77,9 @@ func TestSlugifyTitle(t *testing.T) {
testCases := map[string]string{
"Grafana Play Home": "grafana-play-home",
"snöräv-över-ån": "snorav-over-an",
"漢字": "5ryi5a2X", // "han-zi", // Hanzi for hanzi
"🇦🇶": "8J-HpvCfh7Y", // flag of Antarctica-emoji, using fallback
"𒆠": "8JKGoA", // cuneiform Ki, using fallback
"漢字": "%e6%bc%a2%e5%ad%97", // "han-zi", // Hanzi for hanzi
"🇦🇶": "%f0%9f%87%a6%f0%9f%87%b6", // flag of Antarctica-emoji, using fallback
"𒆠": "%f0%92%86%a0", // cuneiform Ki, using fallback
}
for input, expected := range testCases {