Fix: Template query editor this bind exception fix (#16299)

Also fixes the default 100% width of inputs.
Fixes #16298
This commit is contained in:
Torkel Ödegaard 2019-03-29 14:25:11 +01:00 committed by GitHub
parent 79b86466fd
commit 5c3a0a624a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 37 additions and 13 deletions

View File

@ -72,7 +72,7 @@ export class Input extends PureComponent<Props> {
const inputElementProps = this.populateEventPropsWithStatus(restProps, validationEvents);
return (
<div>
<div style={{ flexGrow: 1 }}>
<input {...inputElementProps} className={inputClassName} />
{error && !hideErrorMessage && <span>{error}</span>}
</div>

View File

@ -1,7 +1,13 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`Input renders correctly 1`] = `
<div>
<div
style={
Object {
"flexGrow": 1,
}
}
>
<input
className="gf-form-input"
/>

View File

@ -467,7 +467,13 @@ exports[`Render should render with base threshold 1`] = `
type="text"
value="Base"
>
<div>
<div
style={
Object {
"flexGrow": 1,
}
}
>
<input
className="gf-form-input"
readOnly={true}

View File

@ -8,13 +8,13 @@ export default class DefaultVariableQueryEditor extends PureComponent<VariableQu
this.state = { value: props.query };
}
handleChange(event) {
this.setState({ value: event.target.value });
}
onChange = (event: React.FormEvent<HTMLInputElement>) => {
this.setState({ value: event.currentTarget.value });
};
handleBlur(event) {
this.props.onChange(event.target.value, event.target.value);
}
onBlur = (event: React.FormEvent<HTMLInputElement>) => {
this.props.onChange(event.currentTarget.value, event.currentTarget.value);
};
render() {
return (
@ -24,8 +24,8 @@ export default class DefaultVariableQueryEditor extends PureComponent<VariableQu
type="text"
className="gf-form-input"
value={this.state.value}
onChange={this.handleChange}
onBlur={this.handleBlur}
onChange={this.onChange}
onBlur={this.onBlur}
placeholder="metric name or tags query"
required
/>

View File

@ -398,7 +398,13 @@ Array [
>
Alias By
</label>
<div>
<div
style={
Object {
"flexGrow": 1,
}
}
>
<input
className="gf-form-input gf-form-input width-24"
onChange={[Function]}
@ -426,7 +432,13 @@ Array [
>
Project
</span>
<div>
<div
style={
Object {
"flexGrow": 1,
}
}
>
<input
className="gf-form-input gf-form-input width-15"
disabled={true}