IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Alerting: Do not exit if Redis ping fails when using redis-based Alertmanager clustering (#74144)

Browse Source 
Do not fail redis peer construction if ping fails
This commit is contained in:
Alexander Weaver 2023-09-05 10:43:13 -05:00 committed by GitHub
parent 34be361299
commit 5c9aeaef41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/services/ngalert/notifier/redis_peer.go
View File

@ -2,7 +2,6 @@ package notifier
import (
"context"
"fmt"
"sort"
"strconv"
"sync"
@ -100,8 +99,9 @@ func newRedisPeer(cfg redisConfig, logger log.Logger, reg prometheus.Registerer,
})
cmd := rdb.Ping(context.Background())
if cmd.Err() != nil {
return nil, fmt.Errorf("failed to ping redis: %w", cmd.Err())
logger.Error("Failed to ping redis - redis-based alertmanager clustering may not be available", "err", cmd.Err())
}
// Make sure that the prefix uses a colon at the end as deliminator.
if cfg.prefix != "" && cfg.prefix[len(cfg.prefix)-1] != ':' {
cfg.prefix = cfg.prefix + ":"