IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-16 18:34:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

Navigation: Remove commandPalette feature toggle (#62698)

Browse Source 
* remove command palette feature toggle

* undo irrelevant AppChrome changes

* update toggle description
This commit is contained in:
Ashley Harrison 2023-02-02 14:44:21 +00:00 committed by GitHub
parent 68862ce3e8
commit 5e7e026c0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 10 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
View File

@ -25,7 +25,6 @@ Some stable features are enabled by default. You can disable a stable feature by
| `database_metrics` | Add Prometheus metrics for database tables | |
| `lokiMonacoEditor` | Access to Monaco query editor for Loki | Yes |
| `featureHighlights` | Highlight Grafana Enterprise features | |
| `commandPalette` | Enable command palette | Yes |
| `cloudWatchDynamicLabels` | Use dynamic labels instead of alias patterns in CloudWatch datasource | Yes |
| `internationalization` | Enables internationalization | Yes |
| `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes |
@ -45,6 +44,7 @@ Some stable features are enabled by default. You can disable a stable feature by
| `newDBLibrary` | Use jmoiron/sqlx rather than xorm for a few backend services |
| `validateDashboardsOnSave` | Validate dashboard JSON POSTed to api/dashboards/db |
| `autoMigrateGraphPanels` | Replace the angular graph panel with timeseries |
| `topnav` | Displays new top nav and page layouts |
| `datasourceLogger` | Logs all datasource requests |
| `accessControlOnCall` | Access control primitives for OnCall |
| `alertingNoNormalState` | Stop maintaining state of alerts that are not firing |
@ -82,7 +82,6 @@ Alpha features might be changed or removed without prior notice.
| `disableSecretsCompatibility` | Disable duplicated secret storage in legacy tables |
| `logRequestsInstrumentedAsUnknown` | Logs the path for requests that are instrumented as unknown |
| `dataConnectionsConsole` | Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins. |
| `topnav` | New top nav and page layouts |
| `flameGraph` | Show the flame graph |
| `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift |
| `athenaAsyncQueryDataSupport` | Enable async query data support for Athena |

1
packages/grafana-data/src/types/featureToggles.gen.ts
View File

@ -49,7 +49,6 @@ export interface FeatureToggles {
export?: boolean;
exploreMixedDatasource?: boolean;
tracing?: boolean;
commandPalette?: boolean;
correlations?: boolean;
cloudWatchDynamicLabels?: boolean;
datasourceQueryMultiStatus?: boolean;

11
pkg/services/featuremgmt/registry.go
View File

@ -189,13 +189,6 @@ var (
State: FeatureStateAlpha,
FrontendOnly: true,
},
{
Name: "commandPalette",
Description: "Enable command palette",
State: FeatureStateStable,
Expression: "true", // enabled by default
FrontendOnly: true,
},
{
Name: "correlations",
Description: "Correlations page",
@ -276,8 +269,8 @@ var (
},
{
Name: "topnav",
Description: "New top nav and page layouts",
State: FeatureStateAlpha,
Description: "Displays new top nav and page layouts",
State: FeatureStateBeta,
},
{
Name: "grpcServer",

6
pkg/services/featuremgmt/toggles_gen.go
View File

@ -139,10 +139,6 @@ const (
// Adds trace ID to error notifications
FlagTracing = "tracing"
// FlagCommandPalette
// Enable command palette
FlagCommandPalette = "commandPalette"
// FlagCorrelations
// Correlations page
FlagCorrelations = "correlations"
@ -200,7 +196,7 @@ const (
FlagInternationalization = "internationalization"
// FlagTopnav
// New top nav and page layouts
// Displays new top nav and page layouts
FlagTopnav = "topnav"
// FlagGrpcServer

2
public/app/core/components/AppChrome/AppChrome.tsx
View File

@ -31,7 +31,7 @@ export function AppChrome({ children }: Props) {
<>
<NavBar />
<SearchWrapper />
{featureToggles.commandPalette && <CommandPalette />}
<CommandPalette />
</>
)}
<main className="main-view">{children}</main>

11
public/app/core/components/AppChrome/TopSearchBar.tsx
View File

@ -26,12 +26,11 @@ export function TopSearchBar() {
const helpNode = navIndex['help'];
const profileNode = navIndex['profile'];
const search =
config.featureToggles.commandPalette && config.featureToggles.topNavCommandPalette ? (
<TopSearchBarCommandPaletteTrigger />
) : (
<TopSearchBarInput />
);
const search = config.featureToggles.topNavCommandPalette ? (
<TopSearchBarCommandPaletteTrigger />
) : (
<TopSearchBarInput />
);
return (
<div className={styles.layout}>