Explore Metrics: Add consistent maxDataPoints value across the app (#93618)

Add consistent maxDataPoints value across the app
This commit is contained in:
ismail simsek 2024-09-25 17:53:26 +02:00 committed by GitHub
parent 2c98767d17
commit 5fe4a2f6a9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 9 deletions

View File

@ -1,7 +1,7 @@
import { SceneObjectState, SceneObjectBase, SceneComponentProps, VizPanel, SceneQueryRunner } from '@grafana/scenes';
import { RadioButtonGroup } from '@grafana/ui';
import { trailDS } from '../shared';
import { MDP_METRIC_OVERVIEW, trailDS } from '../shared';
import { getMetricSceneFor } from '../utils';
import { AutoQueryDef } from './types';
@ -52,7 +52,7 @@ export class AutoVizPanel extends SceneObjectBase<AutoVizPanelState> {
.setData(
new SceneQueryRunner({
datasource: trailDS,
maxDataPoints: 500,
maxDataPoints: MDP_METRIC_OVERVIEW,
queries: def.queries,
})
)

View File

@ -33,7 +33,7 @@ import { MetricScene } from '../MetricScene';
import { StatusWrapper } from '../StatusWrapper';
import { reportExploreMetrics } from '../interactions';
import { ALL_VARIABLE_VALUE } from '../services/variables';
import { trailDS, VAR_FILTERS, VAR_GROUP_BY, VAR_GROUP_BY_EXP } from '../shared';
import { MDP_METRIC_PREVIEW, trailDS, VAR_FILTERS, VAR_GROUP_BY, VAR_GROUP_BY_EXP } from '../shared';
import { getColorByIndex, getTrailFor } from '../utils';
import { AddToFiltersGraphAction } from './AddToFiltersGraphAction';
@ -304,7 +304,7 @@ export function buildAllLayout(
.setTitle(option.label!)
.setData(
new SceneQueryRunner({
maxDataPoints: 250,
maxDataPoints: MDP_METRIC_PREVIEW,
datasource: trailDS,
queries: [
{
@ -395,7 +395,7 @@ function buildNormalLayout(
return new LayoutSwitcher({
$data: new SceneQueryRunner({
datasource: trailDS,
maxDataPoints: 300,
maxDataPoints: MDP_METRIC_PREVIEW,
queries: queryDef.queries,
}),
breakdownLayoutOptions: [

View File

@ -2,7 +2,7 @@ import { PromQuery } from '@grafana/prometheus';
import { SceneCSSGridItem, SceneQueryRunner, SceneVariableSet } from '@grafana/scenes';
import { getAutoQueriesForMetric } from '../AutomaticMetricQueries/AutoQueryEngine';
import { getVariablesWithMetricConstant, trailDS } from '../shared';
import { getVariablesWithMetricConstant, MDP_METRIC_PREVIEW, trailDS } from '../shared';
import { getColorByIndex } from '../utils';
import { SelectMetricAction } from './SelectMetricAction';
@ -29,7 +29,7 @@ export function getPreviewPanelFor(metric: string, index: number, currentFilterC
$behaviors: [hideEmptyPreviews(metric)],
$data: new SceneQueryRunner({
datasource: trailDS,
maxDataPoints: 200,
maxDataPoints: MDP_METRIC_PREVIEW,
queries,
}),
body: vizPanel,

View File

@ -37,11 +37,12 @@ export const trailDS = { uid: VAR_DATASOURCE_EXPR };
// Local storage keys
export const RECENT_TRAILS_KEY = 'grafana.trails.recent';
export const TRAIL_BOOKMARKS_KEY = 'grafana.trails.bookmarks';
export const TRAIL_BREAKDOWN_VIEW_KEY = 'grafana.trails.breakdown.view';
export const MDP_METRIC_PREVIEW = 250;
export const MDP_METRIC_OVERVIEW = 500;
export type MakeOptional<T, K extends keyof T> = Pick<Partial<T>, K> & Omit<T, K>;
export function getVariablesWithMetricConstant(metric: string) {