IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Dashboards: SaveButton not available after changing the folder (#93216)

Browse Source
This commit is contained in:
Laura Fernández 2024-09-25 13:30:36 +02:00 committed by GitHub
parent 8e5459791b
commit 618e4014a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
public/app/features/dashboard-scene/saving/SaveDashboardAsForm.tsx
View File

@ -48,6 +48,7 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
const { state, onSaveDashboard } = useSaveDashboard(false); const { state, onSaveDashboard } = useSaveDashboard(false);
const [contentSent, setContentSent] = useState<{ title?: string; folderUid?: string }>({}); const [contentSent, setContentSent] = useState<{ title?: string; folderUid?: string }>({});
const [hasFolderChanged, setHasFolderChanged] = useState(false);
const onSave = async (overwrite: boolean) => { const onSave = async (overwrite: boolean) => {
const data = getValues(); const data = getValues();
@ -70,10 +71,10 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
</Button> </Button>
); );
const saveButton = (overwrite: boolean) => ( const saveButton = (overwrite: boolean) => {
<SaveButton isValid={isValid} isLoading={state.loading} onSave={onSave} overwrite={overwrite} /> const showSaveButton = !isValid && hasFolderChanged ? true : isValid;
); return <SaveButton isValid={showSaveButton} isLoading={state.loading} onSave={onSave} overwrite={overwrite} />;
};
function renderFooter(error?: Error) { function renderFooter(error?: Error) {
const formValuesMatchContentSent = const formValuesMatchContentSent =
formValues.title.trim() === contentSent.title && formValues.folder.uid === contentSent.folderUid; formValues.title.trim() === contentSent.title && formValues.folder.uid === contentSent.folderUid;
@ -127,6 +128,8 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
<FolderPicker <FolderPicker
onChange={(uid: string | undefined, title: string | undefined) => { onChange={(uid: string | undefined, title: string | undefined) => {
setValue('folder', { uid, title }); setValue('folder', { uid, title });
const folderUid = dashboard.state.meta.folderUid;
setHasFolderChanged(uid !== folderUid);
}} }}
// Old folder picker fields // Old folder picker fields
value={formValues.folder?.uid} value={formValues.folder?.uid}