mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
Cloudwatch: Move deep link creation to the backend (#30206)
* get meta data from dataframe meta * gmdMeta is not used anymore * wip: move deep link creation to backend * Refactor backend. Remove not used front end code * Unit test deep links. Remove not used frontend tests * remove reference to gmdmeta * fix goimports error * fixed after pr feedback * more changes according to pr feedback * fix lint issue * fix bad math expression check and fix bad test * Decrease nesting * put link on first data field only
This commit is contained in:
@@ -70,7 +70,10 @@ export class MetricsQueryEditor extends PureComponent<Props, State> {
|
||||
const metricsQuery = this.props.query as CloudWatchMetricsQuery;
|
||||
const { showMeta } = this.state;
|
||||
const query = normalizeQuery(metricsQuery);
|
||||
const metaDataExist = data && Object.values(data).length && data.state === 'Done';
|
||||
const executedQueries =
|
||||
data && data.series.length && data.series[0].meta && data.state === 'Done'
|
||||
? data.series[0].meta.executedQueryString
|
||||
: null;
|
||||
|
||||
return (
|
||||
<>
|
||||
@@ -150,20 +153,21 @@ export class MetricsQueryEditor extends PureComponent<Props, State> {
|
||||
<label className="gf-form-label">
|
||||
<a
|
||||
onClick={() =>
|
||||
metaDataExist &&
|
||||
executedQueries &&
|
||||
this.setState({
|
||||
showMeta: !showMeta,
|
||||
})
|
||||
}
|
||||
>
|
||||
<Icon name={showMeta ? 'angle-down' : 'angle-right'} /> {showMeta ? 'Hide' : 'Show'} Query Preview
|
||||
<Icon name={showMeta && executedQueries ? 'angle-down' : 'angle-right'} />{' '}
|
||||
{showMeta && executedQueries ? 'Hide' : 'Show'} Query Preview
|
||||
</a>
|
||||
</label>
|
||||
</div>
|
||||
<div className="gf-form gf-form--grow">
|
||||
<div className="gf-form-label gf-form-label--grow" />
|
||||
</div>
|
||||
{showMeta && metaDataExist && (
|
||||
{showMeta && executedQueries && (
|
||||
<table className="filter-table form-inline">
|
||||
<thead>
|
||||
<tr>
|
||||
@@ -174,7 +178,7 @@ export class MetricsQueryEditor extends PureComponent<Props, State> {
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{data?.series?.[0]?.meta?.gmdMeta?.map(({ ID, Expression, Period }: any) => (
|
||||
{JSON.parse(executedQueries).map(({ ID, Expression, Period }: any) => (
|
||||
<tr key={ID}>
|
||||
<td>{ID}</td>
|
||||
<td>{Expression}</td>
|
||||
|
||||
Reference in New Issue
Block a user