Fixed a small bug and added case sensitivity

This commit is contained in:
Hugo Häggmark
2019-01-30 11:28:23 +01:00
parent 0ddaa95d0e
commit 65fb77ce73
2 changed files with 3 additions and 2 deletions

View File

@@ -46,7 +46,7 @@ describe('actionCreatorFactory', () => {
setup(payload);
expect(() => {
actionCreatorFactory<Dummy>('dummy').create();
actionCreatorFactory<Dummy>('DuMmY').create();
}).toThrow();
});
});

View File

@@ -21,7 +21,7 @@ export const actionCreatorFactory = <Payload>(type: string): ActionCreatorFactor
return Object.assign((payload: Payload): GrafanaAction<Payload> => ({ type, payload }), { type });
};
if (allActionCreators.some(t => type === type)) {
if (allActionCreators.some(t => (t && type ? t.toLocaleUpperCase() === type.toLocaleUpperCase() : false))) {
throw new Error(`There is already an actionCreator defined with the type ${type}`);
}
@@ -30,4 +30,5 @@ export const actionCreatorFactory = <Payload>(type: string): ActionCreatorFactor
return { create };
};
// Should only be used by tests
export const resetAllActionCreatorTypes = () => (allActionCreators.length = 0);