IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Loki: Fix error when changing operations with different parameters (#51779)

Browse Source 
* copy defaultParams when changing an operation

* add type and name comparison

* removed name check
This commit is contained in:
Sven Grossmann 2022-07-06 16:52:58 +02:00 committed by GitHub
parent 0a6eeaa636
commit 663f3fcd2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
public/app/plugins/datasource/prometheus/querybuilder/shared/OperationHeader.tsx
View File

@ -79,7 +79,16 @@ export const OperationHeader = React.memo<Props>(
if (value.value) {
// Operation should exist if it is selectable
const newDef = queryModeller.getOperationDef(value.value.id)!;
let changedOp = { ...operation, id: value.value.id };
// copy default params, and override with all current params
const newParams = [...newDef.defaultParams];
for (let i = 0; i < Math.min(operation.params.length, newParams.length); i++) {
if (newDef.params[i].type === def.params[i].type) {
newParams[i] = operation.params[i];
}
}
const changedOp = { ...operation, params: newParams, id: value.value.id };
onChange(index, def.changeTypeHandler ? def.changeTypeHandler(changedOp, newDef) : changedOp);
}
}}