IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

make sure stats are added horizontally and not vertically (#30106)

Browse Source
This commit is contained in:
Erik Sundell 2021-01-18 11:14:14 +01:00 committed by GitHub
parent 3db5abbeec
commit 690a96e434
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
public/app/plugins/datasource/cloudwatch/components/Stats.test.tsx
View File

@ -8,12 +8,14 @@ describe('Stats', () => {
it('should render component', () => { it('should render component', () => {
render( render(
<Stats <Stats
data-testid="stats"
values={['Average', 'Minimum']} values={['Average', 'Minimum']}
variableOptionGroup={{ label: 'templateVar', value: 'templateVar' }} variableOptionGroup={{ label: 'templateVar', value: 'templateVar' }}
onChange={() => {}} onChange={() => {}}
stats={['Average', 'Maximum', 'Minimum', 'Sum', 'SampleCount'].map(toOption)} stats={['Average', 'Maximum', 'Minimum', 'Sum', 'SampleCount'].map(toOption)}
/> />
); );
expect(screen.getByTestId('stats')).toBeInTheDocument(); expect(screen.getByText('Average')).toBeInTheDocument();
expect(screen.getByText('Minimum')).toBeInTheDocument();
}); });
}); });

4
public/app/plugins/datasource/cloudwatch/components/Stats.tsx
View File

@ -14,7 +14,7 @@ const removeText = '-- remove stat --';
const removeOption: SelectableValue<string> = { label: removeText, value: removeText }; const removeOption: SelectableValue<string> = { label: removeText, value: removeText };
export const Stats: FunctionComponent<Props> = ({ stats, values, onChange, variableOptionGroup }) => ( export const Stats: FunctionComponent<Props> = ({ stats, values, onChange, variableOptionGroup }) => (
<div data-testid="stats"> <>
{values && {values &&
values.map((value, index) => ( values.map((value, index) => (
<Segment <Segment
@ -41,5 +41,5 @@ export const Stats: FunctionComponent<Props> = ({ stats, values, onChange, varia
onChange={({ value }) => onChange([...values, value!])} onChange={({ value }) => onChange([...values, value!])}
options={[...stats.filter(({ value }) => !values.includes(value!)), variableOptionGroup]} options={[...stats.filter(({ value }) => !values.includes(value!)), variableOptionGroup]}
/> />
</div> </>
); );