diff --git a/packages/grafana-ui/src/components/Button/Button.tsx b/packages/grafana-ui/src/components/Button/Button.tsx index bfe0ad73563..978d7dea8fa 100644 --- a/packages/grafana-ui/src/components/Button/Button.tsx +++ b/packages/grafana-ui/src/components/Button/Button.tsx @@ -23,12 +23,26 @@ type CommonProps = { className?: string; children?: React.ReactNode; fullWidth?: boolean; + type?: string; }; export type ButtonProps = CommonProps & ButtonHTMLAttributes; export const Button = React.forwardRef( - ({ variant = 'primary', size = 'md', fill = 'solid', icon, fullWidth, children, className, ...otherProps }, ref) => { + ( + { + variant = 'primary', + size = 'md', + fill = 'solid', + icon, + fullWidth, + children, + className, + type = 'button', + ...otherProps + }, + ref + ) => { const theme = useTheme2(); const styles = getButtonStyles({ theme, @@ -45,7 +59,7 @@ export const Button = React.forwardRef( ); return ( - diff --git a/public/app/core/components/ForgottenPassword/ForgottenPassword.tsx b/public/app/core/components/ForgottenPassword/ForgottenPassword.tsx index c375b9bcff1..23f68a715c2 100644 --- a/public/app/core/components/ForgottenPassword/ForgottenPassword.tsx +++ b/public/app/core/components/ForgottenPassword/ForgottenPassword.tsx @@ -59,7 +59,7 @@ export const ForgottenPassword: FC = () => { /> - + Back to login diff --git a/public/app/core/components/Login/LoginForm.tsx b/public/app/core/components/Login/LoginForm.tsx index 9364c5a0c13..7798b75a748 100644 --- a/public/app/core/components/Login/LoginForm.tsx +++ b/public/app/core/components/Login/LoginForm.tsx @@ -49,7 +49,12 @@ export const LoginForm: FC = ({ children, onSubmit, isLoggingIn, password {...register('password', { required: 'Password is required' })} /> - {children} diff --git a/public/app/core/components/SharedPreferences/SharedPreferences.tsx b/public/app/core/components/SharedPreferences/SharedPreferences.tsx index 376bcfc41d7..de072f5189c 100644 --- a/public/app/core/components/SharedPreferences/SharedPreferences.tsx +++ b/public/app/core/components/SharedPreferences/SharedPreferences.tsx @@ -207,7 +207,11 @@ export class SharedPreferences extends PureComponent {
-
diff --git a/public/app/core/components/Signup/VerifyEmail.tsx b/public/app/core/components/Signup/VerifyEmail.tsx index 81eab2cc66b..f01684bb50c 100644 --- a/public/app/core/components/Signup/VerifyEmail.tsx +++ b/public/app/core/components/Signup/VerifyEmail.tsx @@ -61,7 +61,7 @@ export const VerifyEmail: FC = () => { /> - + Back to login diff --git a/public/app/features/admin/AdminEditOrgPage.tsx b/public/app/features/admin/AdminEditOrgPage.tsx index 9afb7c4484c..44bc10e0134 100644 --- a/public/app/features/admin/AdminEditOrgPage.tsx +++ b/public/app/features/admin/AdminEditOrgPage.tsx @@ -85,7 +85,9 @@ export default function AdminEditOrgPage({ match }: Props) { - + )} diff --git a/public/app/features/admin/CrawlerStartButton.tsx b/public/app/features/admin/CrawlerStartButton.tsx index 3cceb47b7f3..69824c08f0f 100644 --- a/public/app/features/admin/CrawlerStartButton.tsx +++ b/public/app/features/admin/CrawlerStartButton.tsx @@ -39,7 +39,9 @@ export const CrawlerStartButton = () => { /> - + diff --git a/public/app/features/alerting/unified/components/admin/AddAlertManagerModal.tsx b/public/app/features/alerting/unified/components/admin/AddAlertManagerModal.tsx index 05cdfebf444..4549e02be71 100644 --- a/public/app/features/alerting/unified/components/admin/AddAlertManagerModal.tsx +++ b/public/app/features/alerting/unified/components/admin/AddAlertManagerModal.tsx @@ -82,7 +82,9 @@ export const AddAlertManagerModal: FC = ({ alertmanagers, onChangeAlertma )}
- +
)} diff --git a/public/app/features/alerting/unified/components/receivers/ReceiversSection.tsx b/public/app/features/alerting/unified/components/receivers/ReceiversSection.tsx index 93c14ce10cd..9c096dc8b60 100644 --- a/public/app/features/alerting/unified/components/receivers/ReceiversSection.tsx +++ b/public/app/features/alerting/unified/components/receivers/ReceiversSection.tsx @@ -33,7 +33,9 @@ export const ReceiversSection: FC = ({ {showButton && ( - + )} diff --git a/public/app/features/alerting/unified/components/receivers/TemplateForm.tsx b/public/app/features/alerting/unified/components/receivers/TemplateForm.tsx index 6d66b8ad83f..1777b4cfe35 100644 --- a/public/app/features/alerting/unified/components/receivers/TemplateForm.tsx +++ b/public/app/features/alerting/unified/components/receivers/TemplateForm.tsx @@ -152,7 +152,11 @@ export const TemplateForm: FC = ({ existing, alertManagerSourceName, conf Saving... )} - {!loading && } + {!loading && ( + + )} = ({ show, onClose, onKeyAdded, disabled })
- +
diff --git a/public/app/features/canvas/elements/button.tsx b/public/app/features/canvas/elements/button.tsx index 03f413012c4..1aebc39d5f9 100644 --- a/public/app/features/canvas/elements/button.tsx +++ b/public/app/features/canvas/elements/button.tsx @@ -27,7 +27,11 @@ class ButtonDisplay extends PureComponent{data?.text}; + return ( + + ); } } diff --git a/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx b/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx index 886716a6af1..1137e6de801 100644 --- a/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx +++ b/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx @@ -41,7 +41,9 @@ const onClose = () => locationService.partial({ editview: null }); const MakeEditable = (props: { onMakeEditable: () => any }) => (
Dashboard not editable
- +
); diff --git a/public/app/features/dashboard/components/DashboardSettings/JsonEditorSettings.tsx b/public/app/features/dashboard/components/DashboardSettings/JsonEditorSettings.tsx index 55e9317942e..7dea62f90a5 100644 --- a/public/app/features/dashboard/components/DashboardSettings/JsonEditorSettings.tsx +++ b/public/app/features/dashboard/components/DashboardSettings/JsonEditorSettings.tsx @@ -54,7 +54,9 @@ export const JsonEditorSettings: React.FC = ({ dashboard }) => { {dashboard.meta.canSave && ( - + )} diff --git a/public/app/features/dashboard/components/SaveDashboard/forms/SaveProvisionedDashboardForm.tsx b/public/app/features/dashboard/components/SaveDashboard/forms/SaveProvisionedDashboardForm.tsx index 8fc0075998e..8fdb65546d6 100644 --- a/public/app/features/dashboard/components/SaveDashboard/forms/SaveProvisionedDashboardForm.tsx +++ b/public/app/features/dashboard/components/SaveDashboard/forms/SaveProvisionedDashboardForm.tsx @@ -67,7 +67,9 @@ export const SaveProvisionedDashboardForm: React.FC = ({ dashboardJSON} onClipboardCopy={onCopyToClipboardSuccess}> Copy JSON to clipboard - +
diff --git a/public/app/features/profile/ChangePasswordForm.tsx b/public/app/features/profile/ChangePasswordForm.tsx index d86dcd1e8e9..07f2553f6eb 100644 --- a/public/app/features/profile/ChangePasswordForm.tsx +++ b/public/app/features/profile/ChangePasswordForm.tsx @@ -69,7 +69,7 @@ export const ChangePasswordForm: FC = ({ user, onChangePassword, isSaving /> - diff --git a/public/app/features/profile/UserProfileEditForm.tsx b/public/app/features/profile/UserProfileEditForm.tsx index f3c8927fbe9..c5748eb515f 100644 --- a/public/app/features/profile/UserProfileEditForm.tsx +++ b/public/app/features/profile/UserProfileEditForm.tsx @@ -74,6 +74,7 @@ export const UserProfileEditForm: FC = ({ user, isSavingUser, updateProfi variant="primary" disabled={isSavingUser} data-testid={selectors.components.UserProfile.profileSaveButton} + type="submit" > Save