IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

feat(alerting): rename state response method

Browse Source
This commit is contained in:
bergquist 2016-06-22 07:23:31 +02:00
parent 403fdebca3
commit 6edae37ac9
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/services/alerting/engine.go
View File

@ -121,20 +121,19 @@ func (e *Engine) resultHandler() {
result.State = alertstates.Critical result.State = alertstates.Critical
result.Description = fmt.Sprintf("Failed to run check after %d retires, Error: %v", maxAlertExecutionRetries, result.Error) result.Description = fmt.Sprintf("Failed to run check after %d retires, Error: %v", maxAlertExecutionRetries, result.Error)
e.saveState(result) e.reactToState(result)
} }
} else { } else {
result.AlertJob.ResetRetry() result.AlertJob.ResetRetry()
e.saveState(result) e.reactToState(result)
} }
} }
} }
func (e *Engine) saveState(result *AlertResult) { func (e *Engine) reactToState(result *AlertResult) {
query := &m.GetAlertByIdQuery{Id: result.AlertJob.Rule.Id} query := &m.GetAlertByIdQuery{Id: result.AlertJob.Rule.Id}
bus.Dispatch(query) bus.Dispatch(query)
e.notifier.Notify(result)
if query.Result.ShouldUpdateState(result.State) { if query.Result.ShouldUpdateState(result.State) {
cmd := &m.UpdateAlertStateCommand{ cmd := &m.UpdateAlertStateCommand{
AlertId: result.AlertJob.Rule.Id, AlertId: result.AlertJob.Rule.Id,
@ -146,9 +145,7 @@ func (e *Engine) saveState(result *AlertResult) {
e.log.Error("Failed to save state", "error", err) e.log.Error("Failed to save state", "error", err)
} }
e.log.Debug("will notify! about", "new state", result.State) e.log.Debug("will notify about new state", "new state", result.State)
e.notifier.Notify(result)
} else {
e.log.Debug("state remains the same!")
} }
} }