Changed functions to arrow functions for only-arrow-functions rule. (#13131)

public/app/core/specs/kbn.test.ts

@@ -2,27 +2,27 @@ import kbn from '../utils/kbn';
 import * as dateMath from '../utils/datemath';
 import moment from 'moment';
 
-describe('unit format menu', function() {
+describe('unit format menu', () => {
   const menu = kbn.getUnitFormats();
-  menu.map(function(submenu) {
-    describe('submenu ' + submenu.text, function() {
-      it('should have a title', function() {
+  menu.map(submenu => {
+    describe('submenu ' + submenu.text, () => {
+      it('should have a title', () => {
         expect(typeof submenu.text).toBe('string');
       });
 
-      it('should have a submenu', function() {
+      it('should have a submenu', () => {
         expect(Array.isArray(submenu.submenu)).toBe(true);
       });
 
-      submenu.submenu.map(function(entry) {
-        describe('entry ' + entry.text, function() {
-          it('should have a title', function() {
+      submenu.submenu.map(entry => {
+        describe('entry ' + entry.text, () => {
+          it('should have a title', () => {
             expect(typeof entry.text).toBe('string');
           });
-          it('should have a format', function() {
+          it('should have a format', () => {
             expect(typeof entry.value).toBe('string');
           });
-          it('should have a valid format', function() {
+          it('should have a valid format', () => {
             expect(typeof kbn.valueFormats[entry.value]).toBe('function');
           });
         });
@@ -32,8 +32,8 @@ describe('unit format menu', function() {
 });
 
 function describeValueFormat(desc, value, tickSize, tickDecimals, result) {
-  describe('value format: ' + desc, function() {
-    it('should translate ' + value + ' as ' + result, function() {
+  describe('value format: ' + desc, () => {
+    it('should translate ' + value + ' as ' + result, () => {
       const scaledDecimals = tickDecimals - Math.floor(Math.log(tickSize) / Math.LN10);
       const str = kbn.valueFormats[desc](value, tickDecimals, scaledDecimals);
       expect(str).toBe(result);
@@ -100,85 +100,85 @@ describeValueFormat('d', 3, 1, 0, '3 day');
 describeValueFormat('d', 245, 100, 0, '35 week');
 describeValueFormat('d', 2456, 10, 0, '6.73 year');
 
-describe('date time formats', function() {
+describe('date time formats', () => {
   const epoch = 1505634997920;
   const utcTime = moment.utc(epoch);
   const browserTime = moment(epoch);
 
-  it('should format as iso date', function() {
+  it('should format as iso date', () => {
     const expected = browserTime.format('YYYY-MM-DD HH:mm:ss');
     const actual = kbn.valueFormats.dateTimeAsIso(epoch);
     expect(actual).toBe(expected);
   });
 
-  it('should format as iso date (in UTC)', function() {
+  it('should format as iso date (in UTC)', () => {
     const expected = utcTime.format('YYYY-MM-DD HH:mm:ss');
     const actual = kbn.valueFormats.dateTimeAsIso(epoch, true);
     expect(actual).toBe(expected);
   });
 
-  it('should format as iso date and skip date when today', function() {
+  it('should format as iso date and skip date when today', () => {
     const now = moment();
     const expected = now.format('HH:mm:ss');
     const actual = kbn.valueFormats.dateTimeAsIso(now.valueOf(), false);
     expect(actual).toBe(expected);
   });
 
-  it('should format as iso date (in UTC) and skip date when today', function() {
+  it('should format as iso date (in UTC) and skip date when today', () => {
     const now = moment.utc();
     const expected = now.format('HH:mm:ss');
     const actual = kbn.valueFormats.dateTimeAsIso(now.valueOf(), true);
     expect(actual).toBe(expected);
   });
 
-  it('should format as US date', function() {
+  it('should format as US date', () => {
     const expected = browserTime.format('MM/DD/YYYY h:mm:ss a');
     const actual = kbn.valueFormats.dateTimeAsUS(epoch, false);
     expect(actual).toBe(expected);
   });
 
-  it('should format as US date (in UTC)', function() {
+  it('should format as US date (in UTC)', () => {
     const expected = utcTime.format('MM/DD/YYYY h:mm:ss a');
     const actual = kbn.valueFormats.dateTimeAsUS(epoch, true);
     expect(actual).toBe(expected);
   });
 
-  it('should format as US date and skip date when today', function() {
+  it('should format as US date and skip date when today', () => {
     const now = moment();
     const expected = now.format('h:mm:ss a');
     const actual = kbn.valueFormats.dateTimeAsUS(now.valueOf(), false);
     expect(actual).toBe(expected);
   });
 
-  it('should format as US date (in UTC) and skip date when today', function() {
+  it('should format as US date (in UTC) and skip date when today', () => {
     const now = moment.utc();
     const expected = now.format('h:mm:ss a');
     const actual = kbn.valueFormats.dateTimeAsUS(now.valueOf(), true);
     expect(actual).toBe(expected);
   });
 
-  it('should format as from now with days', function() {
+  it('should format as from now with days', () => {
     const daysAgo = moment().add(-7, 'd');
     const expected = '7 days ago';
     const actual = kbn.valueFormats.dateTimeFromNow(daysAgo.valueOf(), false);
     expect(actual).toBe(expected);
   });
 
-  it('should format as from now with days (in UTC)', function() {
+  it('should format as from now with days (in UTC)', () => {
     const daysAgo = moment.utc().add(-7, 'd');
     const expected = '7 days ago';
     const actual = kbn.valueFormats.dateTimeFromNow(daysAgo.valueOf(), true);
     expect(actual).toBe(expected);
   });
 
-  it('should format as from now with minutes', function() {
+  it('should format as from now with minutes', () => {
     const daysAgo = moment().add(-2, 'm');
     const expected = '2 minutes ago';
     const actual = kbn.valueFormats.dateTimeFromNow(daysAgo.valueOf(), false);
     expect(actual).toBe(expected);
   });
 
-  it('should format as from now with minutes (in UTC)', function() {
+  it('should format as from now with minutes (in UTC)', () => {
     const daysAgo = moment.utc().add(-2, 'm');
     const expected = '2 minutes ago';
     const actual = kbn.valueFormats.dateTimeFromNow(daysAgo.valueOf(), true);
@@ -186,92 +186,92 @@ describe('date time formats', function() {
   });
 });
 
-describe('kbn.toFixed and negative decimals', function() {
-  it('should treat as zero decimals', function() {
+describe('kbn.toFixed and negative decimals', () => {
+  it('should treat as zero decimals', () => {
     const str = kbn.toFixed(186.123, -2);
     expect(str).toBe('186');
   });
 });
 
-describe('kbn ms format when scaled decimals is null do not use it', function() {
-  it('should use specified decimals', function() {
+describe('kbn ms format when scaled decimals is null do not use it', () => {
+  it('should use specified decimals', () => {
     const str = kbn.valueFormats['ms'](10000086.123, 1, null);
     expect(str).toBe('2.8 hour');
   });
 });
 
-describe('kbn kbytes format when scaled decimals is null do not use it', function() {
-  it('should use specified decimals', function() {
+describe('kbn kbytes format when scaled decimals is null do not use it', () => {
+  it('should use specified decimals', () => {
     const str = kbn.valueFormats['kbytes'](10000000, 3, null);
     expect(str).toBe('9.537 GiB');
   });
 });
 
-describe('kbn deckbytes format when scaled decimals is null do not use it', function() {
-  it('should use specified decimals', function() {
+describe('kbn deckbytes format when scaled decimals is null do not use it', () => {
+  it('should use specified decimals', () => {
     const str = kbn.valueFormats['deckbytes'](10000000, 3, null);
     expect(str).toBe('10.000 GB');
   });
 });
 
-describe('kbn roundValue', function() {
-  it('should should handle null value', function() {
+describe('kbn roundValue', () => {
+  it('should should handle null value', () => {
     const str = kbn.roundValue(null, 2);
     expect(str).toBe(null);
   });
-  it('should round value', function() {
+  it('should round value', () => {
     const str = kbn.roundValue(200.877, 2);
     expect(str).toBe(200.88);
   });
 });
 
-describe('calculateInterval', function() {
-  it('1h 100 resultion', function() {
+describe('calculateInterval', () => {
+  it('1h 100 resultion', () => {
     const range = { from: dateMath.parse('now-1h'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 100, null);
     expect(res.interval).toBe('30s');
   });
 
-  it('10m 1600 resolution', function() {
+  it('10m 1600 resolution', () => {
     const range = { from: dateMath.parse('now-10m'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 1600, null);
     expect(res.interval).toBe('500ms');
     expect(res.intervalMs).toBe(500);
   });
 
-  it('fixed user min interval', function() {
+  it('fixed user min interval', () => {
     const range = { from: dateMath.parse('now-10m'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 1600, '10s');
     expect(res.interval).toBe('10s');
     expect(res.intervalMs).toBe(10000);
   });
 
-  it('short time range and user low limit', function() {
+  it('short time range and user low limit', () => {
     const range = { from: dateMath.parse('now-10m'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 1600, '>10s');
     expect(res.interval).toBe('10s');
   });
 
-  it('large time range and user low limit', function() {
+  it('large time range and user low limit', () => {
     const range = { from: dateMath.parse('now-14d'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 1000, '>10s');
     expect(res.interval).toBe('20m');
   });
 
-  it('10s 900 resolution and user low limit in ms', function() {
+  it('10s 900 resolution and user low limit in ms', () => {
     const range = { from: dateMath.parse('now-10s'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 900, '>15ms');
     expect(res.interval).toBe('15ms');
   });
 
-  it('1d 1 resolution', function() {
+  it('1d 1 resolution', () => {
     const range = { from: dateMath.parse('now-1d'), to: dateMath.parse('now') };
     const res = kbn.calculateInterval(range, 1, null);
     expect(res.interval).toBe('1d');
     expect(res.intervalMs).toBe(86400000);
   });
 
-  it('86399s 1 resolution', function() {
+  it('86399s 1 resolution', () => {
     const range = {
       from: dateMath.parse('now-86390s'),
       to: dateMath.parse('now'),
@@ -282,140 +282,140 @@ describe('calculateInterval', function() {
   });
 });
 
-describe('hex', function() {
-  it('positive integer', function() {
+describe('hex', () => {
+  it('positive integer', () => {
     const str = kbn.valueFormats.hex(100, 0);
     expect(str).toBe('64');
   });
-  it('negative integer', function() {
+  it('negative integer', () => {
     const str = kbn.valueFormats.hex(-100, 0);
     expect(str).toBe('-64');
   });
-  it('null', function() {
+  it('null', () => {
     const str = kbn.valueFormats.hex(null, 0);
     expect(str).toBe('');
   });
-  it('positive float', function() {
+  it('positive float', () => {
     const str = kbn.valueFormats.hex(50.52, 1);
     expect(str).toBe('32.8');
   });
-  it('negative float', function() {
+  it('negative float', () => {
     const str = kbn.valueFormats.hex(-50.333, 2);
     expect(str).toBe('-32.547AE147AE14');
   });
 });
 
-describe('hex 0x', function() {
-  it('positive integeter', function() {
+describe('hex 0x', () => {
+  it('positive integeter', () => {
     const str = kbn.valueFormats.hex0x(7999, 0);
     expect(str).toBe('0x1F3F');
   });
-  it('negative integer', function() {
+  it('negative integer', () => {
     const str = kbn.valueFormats.hex0x(-584, 0);
     expect(str).toBe('-0x248');
   });
-  it('null', function() {
+  it('null', () => {
     const str = kbn.valueFormats.hex0x(null, 0);
     expect(str).toBe('');
   });
-  it('positive float', function() {
+  it('positive float', () => {
     const str = kbn.valueFormats.hex0x(74.443, 3);
     expect(str).toBe('0x4A.716872B020C4');
   });
-  it('negative float', function() {
+  it('negative float', () => {
     const str = kbn.valueFormats.hex0x(-65.458, 1);
     expect(str).toBe('-0x41.8');
   });
 });
 
-describe('duration', function() {
-  it('null', function() {
+describe('duration', () => {
+  it('null', () => {
     const str = kbn.toDuration(null, 0, 'millisecond');
     expect(str).toBe('');
   });
-  it('0 milliseconds', function() {
+  it('0 milliseconds', () => {
     const str = kbn.toDuration(0, 0, 'millisecond');
     expect(str).toBe('0 milliseconds');
   });
-  it('1 millisecond', function() {
+  it('1 millisecond', () => {
     const str = kbn.toDuration(1, 0, 'millisecond');
     expect(str).toBe('1 millisecond');
   });
-  it('-1 millisecond', function() {
+  it('-1 millisecond', () => {
     const str = kbn.toDuration(-1, 0, 'millisecond');
     expect(str).toBe('1 millisecond ago');
   });
-  it('seconds', function() {
+  it('seconds', () => {
     const str = kbn.toDuration(1, 0, 'second');
     expect(str).toBe('1 second');
   });
-  it('minutes', function() {
+  it('minutes', () => {
     const str = kbn.toDuration(1, 0, 'minute');
     expect(str).toBe('1 minute');
   });
-  it('hours', function() {
+  it('hours', () => {
     const str = kbn.toDuration(1, 0, 'hour');
     expect(str).toBe('1 hour');
   });
-  it('days', function() {
+  it('days', () => {
     const str = kbn.toDuration(1, 0, 'day');
     expect(str).toBe('1 day');
   });
-  it('weeks', function() {
+  it('weeks', () => {
     const str = kbn.toDuration(1, 0, 'week');
     expect(str).toBe('1 week');
   });
-  it('months', function() {
+  it('months', () => {
     const str = kbn.toDuration(1, 0, 'month');
     expect(str).toBe('1 month');
   });
-  it('years', function() {
+  it('years', () => {
     const str = kbn.toDuration(1, 0, 'year');
     expect(str).toBe('1 year');
   });
-  it('decimal days', function() {
+  it('decimal days', () => {
     const str = kbn.toDuration(1.5, 2, 'day');
     expect(str).toBe('1 day, 12 hours, 0 minutes');
   });
-  it('decimal months', function() {
+  it('decimal months', () => {
     const str = kbn.toDuration(1.5, 3, 'month');
     expect(str).toBe('1 month, 2 weeks, 1 day, 0 hours');
   });
-  it('no decimals', function() {
+  it('no decimals', () => {
     const str = kbn.toDuration(38898367008, 0, 'millisecond');
     expect(str).toBe('1 year');
   });
-  it('1 decimal', function() {
+  it('1 decimal', () => {
     const str = kbn.toDuration(38898367008, 1, 'millisecond');
     expect(str).toBe('1 year, 2 months');
   });
-  it('too many decimals', function() {
+  it('too many decimals', () => {
     const str = kbn.toDuration(38898367008, 20, 'millisecond');
     expect(str).toBe('1 year, 2 months, 3 weeks, 4 days, 5 hours, 6 minutes, 7 seconds, 8 milliseconds');
   });
-  it('floating point error', function() {
+  it('floating point error', () => {
     const str = kbn.toDuration(36993906007, 8, 'millisecond');
     expect(str).toBe('1 year, 2 months, 0 weeks, 3 days, 4 hours, 5 minutes, 6 seconds, 7 milliseconds');
   });
 });
 
-describe('volume', function() {
-  it('1000m3', function() {
+describe('volume', () => {
+  it('1000m3', () => {
     const str = kbn.valueFormats['m3'](1000, 1, null);
     expect(str).toBe('1000.0 m³');
   });
 });
 
-describe('hh:mm:ss', function() {
-  it('00:04:06', function() {
+describe('hh:mm:ss', () => {
+  it('00:04:06', () => {
     const str = kbn.valueFormats['dthms'](246, 1);
     expect(str).toBe('00:04:06');
   });
-  it('24:00:00', function() {
+  it('24:00:00', () => {
     const str = kbn.valueFormats['dthms'](86400, 1);
     expect(str).toBe('24:00:00');
   });
-  it('6824413:53:20', function() {
+  it('6824413:53:20', () => {
     const str = kbn.valueFormats['dthms'](24567890000, 1);
     expect(str).toBe('6824413:53:20');
   });