From 744f4defcfe90ad40059ed8538a01ca83f6002f7 Mon Sep 17 00:00:00 2001 From: Ieva Date: Thu, 26 Oct 2023 17:39:27 +0100 Subject: [PATCH] Bug: fix a typo in dashboard permission logic (#77231) fix an error handling typo --- pkg/services/dashboards/service/dashboard_service.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/services/dashboards/service/dashboard_service.go b/pkg/services/dashboards/service/dashboard_service.go index c01469a4694..6175599b0dd 100644 --- a/pkg/services/dashboards/service/dashboard_service.go +++ b/pkg/services/dashboards/service/dashboard_service.go @@ -482,9 +482,7 @@ func (dr *DashboardServiceImpl) setDefaultPermissions(ctx context.Context, dto * if err != nil { dr.log.Error("Could not make user admin", "dashboard", dash.Title, "namespaceID", namespaceID, "userID", userID, "error", err) - } - - if err != nil && namespaceID == identity.NamespaceUser && userID > 0 { + } else if namespaceID == identity.NamespaceUser && userID > 0 { permissions = append(permissions, accesscontrol.SetResourcePermissionCommand{ UserID: userID, Permission: dashboards.PERMISSION_ADMIN.String(), })