IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issues with plus button in threshold and panel option header, and current state in viz picker, fixes #15329

Browse Source
This commit is contained in:
Torkel Ödegaard
2019-02-08 21:53:51 +01:00
parent db8c74c4c3
commit 748cb44911
4 changed files with 26 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
public/app/features/dashboard/panel_editor/VisualizationTab.tsx
View File

@@ -119,7 +119,12 @@ export class VisualizationTab extends PureComponent<Props, State> {
template +=
`
<div class="panel-options-group" ng-cloak>` +
(i > 0 ? `<div class="panel-options-group__header">{{ctrl.editorTabs[${i}].title}}</div>` : '') +
(i > 0
? `<div class="panel-options-group__header">
<span class="panel-options-group__title">{{ctrl.editorTabs[${i}].title}}
</span>
</div>`
: '') +
`<div class="panel-options-group__body">
<panel-editor-tab editor-tab="ctrl.editorTabs[${i}]" ctrl="ctrl"></panel-editor-tab>
</div>
@@ -228,8 +233,13 @@ export class VisualizationTab extends PureComponent<Props, State> {
};
return (
<EditorTabBody heading="Visualization" renderToolbar={this.renderToolbar} toolbarItems={[pluginHelp]}
scrollTop={scrollTop} setScrollTop={this.setScrollTop}>
<EditorTabBody
heading="Visualization"
renderToolbar={this.renderToolbar}
toolbarItems={[pluginHelp]}
scrollTop={scrollTop}
setScrollTop={this.setScrollTop}
>
<>
<FadeIn in={isVizPickerOpen} duration={200} unmountOnExit={true}>
<VizTypePicker
@@ -247,11 +257,11 @@ export class VisualizationTab extends PureComponent<Props, State> {
}
const mapStateToProps = (state: StoreState) => ({
urlOpenVizPicker: !!state.location.query.openVizPicker
urlOpenVizPicker: !!state.location.query.openVizPicker,
});
const mapDispatchToProps = {
updateLocation
updateLocation,
};
export default connectWithStore(VisualizationTab, mapStateToProps, mapDispatchToProps);

12
public/sass/components/_panel_editor.scss
View File

@@ -146,15 +146,17 @@
padding-bottom: 6px;
transition: transform 1 ease;
&--current {
box-shadow: 0 0 6px $orange;
border: 1px solid $orange;
}
&:hover {
box-shadow: $panel-editor-viz-item-shadow-hover;
background: $panel-editor-viz-item-bg-hover;
border: $panel-editor-viz-item-border-hover;
}
&--current {
box-shadow: 0 0 6px $orange !important;
border: 1px solid $orange !important;
background: $panel-editor-viz-item-bg !important;
}
}