IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

pkg/web: avoid shared middleware slice (#58458)

Browse Source
This commit is contained in:
Emil Tullstedt 2022-11-08 16:58:04 +01:00 committed by GitHub
parent 2e6761b4e4
commit 75701695d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/web/macaron.go
View File

@ -144,8 +144,14 @@ func mwFromHandler(handler Handler) Middleware {
} }
func (m *Macaron) createContext(rw http.ResponseWriter, req *http.Request) *Context { func (m *Macaron) createContext(rw http.ResponseWriter, req *http.Request) *Context {
// NOTE: we have to explicitly copy the middleware chain here to avoid
// passing a shared slice to the *Context, which leads to racy behavior in
// case of later appends
mws := make([]Middleware, len(m.mws))
copy(mws, m.mws)
c := &Context{ c := &Context{
mws: m.mws, mws: mws,
Resp: NewResponseWriter(req.Method, rw), Resp: NewResponseWriter(req.Method, rw),
} }