From 757d6f322e211da19af70b9f7455e3dbeb667243 Mon Sep 17 00:00:00 2001 From: David Kaltschmidt Date: Wed, 2 Jan 2019 11:32:12 +0000 Subject: [PATCH] s/initialDatasourceId/initialDatasource/ --- public/app/core/utils/explore.test.ts | 8 ++++---- public/app/core/utils/explore.ts | 2 +- public/app/features/explore/Explore.tsx | 14 +++++++------- public/app/types/explore.ts | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/public/app/core/utils/explore.test.ts b/public/app/core/utils/explore.test.ts index fcd92681004..a3b08516d16 100644 --- a/public/app/core/utils/explore.test.ts +++ b/public/app/core/utils/explore.test.ts @@ -68,7 +68,7 @@ describe('state functions', () => { it('returns url parameter value for a state object', () => { const state = { ...DEFAULT_EXPLORE_STATE, - initialDatasourceId: 'foo', + initialDatasource: 'foo', range: { from: 'now-5h', to: 'now', @@ -93,7 +93,7 @@ describe('state functions', () => { it('returns url parameter value for a state object', () => { const state = { ...DEFAULT_EXPLORE_STATE, - initialDatasourceId: 'foo', + initialDatasource: 'foo', range: { from: 'now-5h', to: 'now', @@ -119,7 +119,7 @@ describe('state functions', () => { it('can parse the serialized state into the original state', () => { const state = { ...DEFAULT_EXPLORE_STATE, - initialDatasourceId: 'foo', + initialDatasource: 'foo', range: { from: 'now - 5h', to: 'now', @@ -143,7 +143,7 @@ describe('state functions', () => { const resultState = { ...rest, datasource: DEFAULT_EXPLORE_STATE.datasource, - initialDatasourceId: datasource, + initialDatasource: datasource, initialQueries: queries, }; diff --git a/public/app/core/utils/explore.ts b/public/app/core/utils/explore.ts index 1927c616d50..bea166075dc 100644 --- a/public/app/core/utils/explore.ts +++ b/public/app/core/utils/explore.ts @@ -105,7 +105,7 @@ export function parseUrlState(initial: string | undefined): ExploreUrlState { export function serializeStateToUrlParam(state: ExploreState, compact?: boolean): string { const urlState: ExploreUrlState = { - datasource: state.initialDatasourceId, + datasource: state.initialDatasource, queries: state.initialQueries.map(clearQueryKeys), range: state.range, }; diff --git a/public/app/features/explore/Explore.tsx b/public/app/features/explore/Explore.tsx index 11e9becb9bb..a905034f302 100644 --- a/public/app/features/explore/Explore.tsx +++ b/public/app/features/explore/Explore.tsx @@ -95,7 +95,7 @@ export class Explore extends React.PureComponent { /** * Set via URL or local storage */ - initialDatasourceId: string; + initialDatasource: string; /** * Current query expressions of the rows including their modifications, used for running queries. * Not kept in component state to prevent edit-render roundtrips. @@ -121,7 +121,7 @@ export class Explore extends React.PureComponent { initialQueries = splitState.initialQueries; } else { const { datasource, queries, range } = props.urlState as ExploreUrlState; - const initialDatasourceId = datasource || store.get(LAST_USED_DATASOURCE_KEY); + const initialDatasource = datasource || store.get(LAST_USED_DATASOURCE_KEY); initialQueries = ensureQueries(queries); const initialRange = { from: parseTime(range.from), to: parseTime(range.to) } || { ...DEFAULT_RANGE }; // Millies step for helper bar charts @@ -134,7 +134,7 @@ export class Explore extends React.PureComponent { exploreDatasources: [], graphInterval: initialGraphInterval, graphResult: [], - initialDatasourceId, + initialDatasource, initialQueries, history: [], logsResult: null, @@ -158,7 +158,7 @@ export class Explore extends React.PureComponent { async componentDidMount() { const { datasourceSrv } = this.props; - const { initialDatasourceId } = this.state; + const { initialDatasource } = this.state; if (!datasourceSrv) { throw new Error('No datasource service passed as props.'); } @@ -174,8 +174,8 @@ export class Explore extends React.PureComponent { this.setState({ datasourceLoading: true, exploreDatasources }); // Priority for datasource preselection: URL, localstorage, default datasource let datasource; - if (initialDatasourceId) { - datasource = await datasourceSrv.get(initialDatasourceId); + if (initialDatasource) { + datasource = await datasourceSrv.get(initialDatasource); } else { datasource = await datasourceSrv.get(); } @@ -260,7 +260,7 @@ export class Explore extends React.PureComponent { supportsLogs, supportsTable, datasourceLoading: false, - initialDatasourceId: datasource.name, + initialDatasource: datasource.name, initialQueries: nextQueries, logsHighlighterExpressions: undefined, showingStartPage: Boolean(StartPage), diff --git a/public/app/types/explore.ts b/public/app/types/explore.ts index 7ea0462900d..c2c59d35f5b 100644 --- a/public/app/types/explore.ts +++ b/public/app/types/explore.ts @@ -159,7 +159,7 @@ export interface ExploreState { graphInterval: number; // in ms graphResult?: any[]; history: HistoryItem[]; - initialDatasourceId?: string; + initialDatasource?: string; initialQueries: DataQuery[]; logsHighlighterExpressions?: string[]; logsResult?: LogsModel;