diff --git a/pkg/services/login/loginservice/loginservice.go b/pkg/services/login/loginservice/loginservice.go index b32129b0578..d016eca7807 100644 --- a/pkg/services/login/loginservice/loginservice.go +++ b/pkg/services/login/loginservice/loginservice.go @@ -310,12 +310,13 @@ func (ls *Implementation) syncOrgRoles(ctx context.Context, usr *user.User, extU logger.Error(err.Error(), "userId", cmd.UserID, "orgId", cmd.OrgID) continue } - if err := ls.accessControl.DeleteUserPermissions(ctx, orgId, cmd.UserID); err != nil { - logger.Warn("failed to delete permissions for user", "userID", cmd.UserID, "orgID", orgId) - } return err } + + if err := ls.accessControl.DeleteUserPermissions(ctx, orgId, cmd.UserID); err != nil { + logger.Warn("failed to delete permissions for user", "error", err, "userID", cmd.UserID, "orgID", orgId) + } } // update user's default org if needed diff --git a/pkg/services/login/loginservice/loginservice_test.go b/pkg/services/login/loginservice/loginservice_test.go index 7b79d7ccc94..a3d6f28b012 100644 --- a/pkg/services/login/loginservice/loginservice_test.go +++ b/pkg/services/login/loginservice/loginservice_test.go @@ -9,6 +9,7 @@ import ( "github.com/go-kit/log" "github.com/go-kit/log/level" "github.com/grafana/grafana/pkg/models" + "github.com/grafana/grafana/pkg/services/accesscontrol/actest" "github.com/grafana/grafana/pkg/services/login" "github.com/grafana/grafana/pkg/services/login/logintest" "github.com/grafana/grafana/pkg/services/org" @@ -54,6 +55,7 @@ func Test_syncOrgRoles_whenTryingToRemoveLastOrgLogsError(t *testing.T) { AuthInfoService: authInfoMock, userService: usertest.NewUserServiceFake(), orgService: orgService, + accessControl: &actest.FakeService{}, } err := login.syncOrgRoles(context.Background(), &user, &externalUser)