IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

loki: backend: better error-handling-tests (#49213)

Browse Source
This commit is contained in:
Gábor Farkas 2022-05-19 14:26:40 +02:00 committed by GitHub
parent 3da1bf160e
commit 78e22aac59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/tsdb/loki/framing_test.go
View File

@ -74,8 +74,7 @@ func TestErrorResponse(t *testing.T) {
// NOTE: when there is an error-response, it comes with
// HTTP code 400, and the format seems to change between versions:
// 2.3.x: content-type=text/plain, content is plaintext
// 2.4.x: content-type=application/json, content is plaintext: https://github.com/grafana/loki/issues/4844
// main-branch: content-type=application/json, content is JSON
// 2.4.x+: content-type=application/json, content is plaintext: https://github.com/grafana/loki/issues/4844
// we should always be able to to return some kind of error message
tt := []struct {
name string
@ -95,7 +94,7 @@ func TestErrorResponse(t *testing.T) {
errorMessage: "parse error at line 1, col 8: something is wrong",
},
{
name: "parse a non-json error body with json content type (loki 2.4.0,2.4.1,2.4.2)",
name: "parse a non-json error body with json content type",
body: []byte("parse error at line 1, col 8: something is wrong"),
contentType: "application/json; charset=UTF-8",
errorMessage: "parse error at line 1, col 8: something is wrong",