IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Enable remaining jsx-a11y rules (#70990)

Browse Source 
enabling remaining a11y rules + ignore existing violations
This commit is contained in:
Ashley Harrison
2023-06-30 16:58:16 +01:00
committed by GitHub
parent f32f1859a0
commit 7a2a5dde8b
28 changed files with 63 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/app/features/dashboard/dashgrid/PanelHeader/PanelHeaderLoadingIndicator.tsx
View File

@@ -14,6 +14,8 @@ export const PanelHeaderLoadingIndicator = ({ state, onClick }: Props) => {
if (state === LoadingState.Loading) {
return (
// TODO: fix keyboard a11y
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
<div className="panel-loading" onClick={onClick}>
<Tooltip content="Cancel query">
<Icon className="panel-loading__spinner spin-clockwise" name="sync" />
@@ -24,6 +26,8 @@ export const PanelHeaderLoadingIndicator = ({ state, onClick }: Props) => {
if (state === LoadingState.Streaming) {
return (
// TODO: fix keyboard a11y
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
<div className="panel-loading" onClick={onClick}>
<div title="Streaming (click to stop)" className={styles.streamIndicator} />
</div>

2
public/app/features/dashboard/dashgrid/PanelHeader/PanelHeaderMenuTrigger.tsx
View File

@@ -35,6 +35,8 @@ export function PanelHeaderMenuTrigger({ children, onOpenMenu, ...divProps }: Pr
}, []);
return (
// TODO: fix keyboard a11y
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
<header {...divProps} className="panel-title-container" onClick={onMenuToggle} onMouseDown={onMouseDown}>
{children({ panelMenuOpen, closeMenu: () => setPanelMenuOpen(false) })}
</header>