Replace the DS drawer toggle with the new DS picker one (#66551)

This commit is contained in:
Ivan Ortega Alba 2023-04-14 13:01:10 +02:00 committed by GitHub
parent d84bbfd51b
commit 7bc31ab04b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 15 additions and 15 deletions

View File

@ -92,7 +92,6 @@ Alpha features might be changed or removed without prior notice.
| `lokiQuerySplittingConfig` | Give users the option to configure split durations for Loki queries |
| `individualCookiePreferences` | Support overriding cookie preferences per user |
| `onlyExternalOrgRoleSync` | Prohibits a user from changing organization roles synced with external auth providers |
| `drawerDataSourcePicker` | Changes the user experience for data source selection to a drawer. |
| `traceqlSearch` | Enables the 'TraceQL Search' tab for the Tempo datasource which provides a UI to generate TraceQL queries |
| `prometheusMetricEncyclopedia` | Replaces the Prometheus query builder metric select option with a paginated and filterable component |
| `timeSeriesTable` | Enable time series table transformer & sparkline cell type |
@ -109,6 +108,7 @@ Alpha features might be changed or removed without prior notice.
| `pyroscopeFlameGraph` | Changes flame graph to pyroscope one |
| `dataplaneFrontendFallback` | Support dataplane contract field name change for transformations and field name matchers where the name is different |
| `authenticationConfigUI` | Enables authentication configuration UI |
| `advancedDataSourcePicker` | Enable a new data source picker with contextual information, recently used order, CSV upload and advanced mode |
## Development feature toggles

View File

@ -76,7 +76,6 @@ export interface FeatureToggles {
lokiQuerySplittingConfig?: boolean;
individualCookiePreferences?: boolean;
onlyExternalOrgRoleSync?: boolean;
drawerDataSourcePicker?: boolean;
traceqlSearch?: boolean;
prometheusMetricEncyclopedia?: boolean;
timeSeriesTable?: boolean;
@ -97,4 +96,5 @@ export interface FeatureToggles {
useCachingService?: boolean;
enableElasticsearchBackendQuerying?: boolean;
authenticationConfigUI?: boolean;
advancedDataSourcePicker?: boolean;
}

View File

@ -391,13 +391,6 @@ var (
State: FeatureStateAlpha,
Owner: grafanaAuthnzSquad,
},
{
Name: "drawerDataSourcePicker",
Description: "Changes the user experience for data source selection to a drawer.",
State: FeatureStateAlpha,
FrontendOnly: true,
Owner: grafanaBiSquad,
},
{
Name: "traceqlSearch",
Description: "Enables the 'TraceQL Search' tab for the Tempo datasource which provides a UI to generate TraceQL queries",
@ -526,5 +519,12 @@ var (
State: FeatureStateAlpha,
Owner: grafanaAuthnzSquad,
},
{
Name: "advancedDataSourcePicker",
Description: "Enable a new data source picker with contextual information, recently used order, CSV upload and advanced mode",
State: FeatureStateAlpha,
FrontendOnly: true,
Owner: grafanaDashboardsSquad,
},
}
)

View File

@ -57,7 +57,6 @@ lokiQuerySplitting,alpha,@grafana/observability-logs,false,false,false,true
lokiQuerySplittingConfig,alpha,@grafana/observability-logs,false,false,false,true
individualCookiePreferences,alpha,@grafana/backend-platform,false,false,false,false
onlyExternalOrgRoleSync,alpha,@grafana/grafana-authnz-team,false,false,false,false
drawerDataSourcePicker,alpha,@grafana/grafana-bi-squad,false,false,false,true
traceqlSearch,alpha,@grafana/observability-traces-and-profiling,false,false,false,true
prometheusMetricEncyclopedia,alpha,@grafana/observability-metrics,false,false,false,true
timeSeriesTable,alpha,@grafana/app-o11y,false,false,false,true
@ -78,3 +77,4 @@ dataplaneFrontendFallback,alpha,@grafana/observability-metrics,false,false,false
useCachingService,stable,@grafana/grafana-operator-experience-squad,false,false,true,false
enableElasticsearchBackendQuerying,beta,@grafana/observability-logs,false,false,false,false
authenticationConfigUI,alpha,@grafana/grafana-authnz-team,false,false,false,false
advancedDataSourcePicker,alpha,@grafana/dashboards-squad,false,false,false,true

1 Name State Owner requiresDevMode RequiresLicense RequiresRestart FrontendOnly
57 lokiQuerySplittingConfig alpha @grafana/observability-logs false false false true
58 individualCookiePreferences alpha @grafana/backend-platform false false false false
59 onlyExternalOrgRoleSync alpha @grafana/grafana-authnz-team false false false false
drawerDataSourcePicker alpha @grafana/grafana-bi-squad false false false true
60 traceqlSearch alpha @grafana/observability-traces-and-profiling false false false true
61 prometheusMetricEncyclopedia alpha @grafana/observability-metrics false false false true
62 timeSeriesTable alpha @grafana/app-o11y false false false true
77 useCachingService stable @grafana/grafana-operator-experience-squad false false true false
78 enableElasticsearchBackendQuerying beta @grafana/observability-logs false false false false
79 authenticationConfigUI alpha @grafana/grafana-authnz-team false false false false
80 advancedDataSourcePicker alpha @grafana/dashboards-squad false false false true

View File

@ -239,10 +239,6 @@ const (
// Prohibits a user from changing organization roles synced with external auth providers
FlagOnlyExternalOrgRoleSync = "onlyExternalOrgRoleSync"
// FlagDrawerDataSourcePicker
// Changes the user experience for data source selection to a drawer.
FlagDrawerDataSourcePicker = "drawerDataSourcePicker"
// FlagTraceqlSearch
// Enables the 'TraceQL Search' tab for the Tempo datasource which provides a UI to generate TraceQL queries
FlagTraceqlSearch = "traceqlSearch"
@ -322,4 +318,8 @@ const (
// FlagAuthenticationConfigUI
// Enables authentication configuration UI
FlagAuthenticationConfigUI = "authenticationConfigUI"
// FlagAdvancedDataSourcePicker
// Enable a new data source picker with contextual information, recently used order, CSV upload and advanced mode
FlagAdvancedDataSourcePicker = "advancedDataSourcePicker"
)

View File

@ -214,7 +214,7 @@ export class QueryGroup extends PureComponent<Props, State> {
Data source
</InlineFormLabel>
<div className={styles.dataSourceRowItem}>
{config.featureToggles.drawerDataSourcePicker ? (
{config.featureToggles.advancedDataSourcePicker ? (
<DataSourcePickerWithHistory
onChange={this.onChangeDataSource}
current={options.dataSource}