IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

QueryEditor: handle query.hide changes in angular based query-editors (#31336)

Browse Source 
* handle query.hide changes in angular query-editors

* better comment
This commit is contained in:
Gábor Farkas 2021-02-19 09:49:59 +01:00 committed by GitHub
parent 2b7628c69e
commit 7ccba047c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
public/app/features/query/components/QueryEditorRow.tsx
View File

@ -80,6 +80,8 @@ export class QueryEditorRow extends PureComponent<Props, State> {
const panel = new PanelModel({ targets: queries }); const panel = new PanelModel({ targets: queries });
const dashboard = {} as DashboardModel; const dashboard = {} as DashboardModel;
const me = this;
return { return {
datasource: datasource, datasource: datasource,
target: query, target: query,
@ -89,6 +91,14 @@ export class QueryEditorRow extends PureComponent<Props, State> {
// Old angular editors modify the query model and just call refresh // Old angular editors modify the query model and just call refresh
// Important that this use this.props here so that as this fuction is only created on mount and it's // Important that this use this.props here so that as this fuction is only created on mount and it's
// important not to capture old prop functions in this closure // important not to capture old prop functions in this closure
// the "hide" attribute of the quries can be changed from the "outside",
// it will be applied to "this.props.query.hide", but not to "query.hide".
// so we have to apply it.
if (query.hide !== me.props.query.hide) {
query.hide = me.props.query.hide;
}
this.props.onChange(query); this.props.onChange(query);
this.props.onRunQuery(); this.props.onRunQuery();
}, },