mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
QueryEditor: handle query.hide changes in angular based query-editors (#31336)
* handle query.hide changes in angular query-editors * better comment
This commit is contained in:
parent
2b7628c69e
commit
7ccba047c6
@ -80,6 +80,8 @@ export class QueryEditorRow extends PureComponent<Props, State> {
|
||||
const panel = new PanelModel({ targets: queries });
|
||||
const dashboard = {} as DashboardModel;
|
||||
|
||||
const me = this;
|
||||
|
||||
return {
|
||||
datasource: datasource,
|
||||
target: query,
|
||||
@ -89,6 +91,14 @@ export class QueryEditorRow extends PureComponent<Props, State> {
|
||||
// Old angular editors modify the query model and just call refresh
|
||||
// Important that this use this.props here so that as this fuction is only created on mount and it's
|
||||
// important not to capture old prop functions in this closure
|
||||
|
||||
// the "hide" attribute of the quries can be changed from the "outside",
|
||||
// it will be applied to "this.props.query.hide", but not to "query.hide".
|
||||
// so we have to apply it.
|
||||
if (query.hide !== me.props.query.hide) {
|
||||
query.hide = me.props.query.hide;
|
||||
}
|
||||
|
||||
this.props.onChange(query);
|
||||
this.props.onRunQuery();
|
||||
},
|
||||
|
Loading…
Reference in New Issue
Block a user