IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-08-26 13:27:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Tab: Improve accessible name (#89602)

Browse Source 
* replace aria-label selector with data-testid

* fix unit tests

* fix e2e selectors

* fix last unit test

* fix e2e tests

* fix casing

* fix e2e test

* fix casing
This commit is contained in:
Ashley Harrison
2024-06-24 17:48:26 +01:00
committed by GitHub
parent 5a8eff096a
commit 7d8afd9578
20 changed files with 63 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/dashboards-suite/dashboard-public-create.spec.ts
+3 -3
View File
@@ -17,7 +17,7 @@ describe('Public dashboards', () => {
e2e.pages.Dashboard.DashNav.shareButton().click();
// Select public dashboards tab
e2e.pages.ShareDashboardModal.PublicDashboard.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
// Create button should be disabled
e2e.pages.ShareDashboardModal.PublicDashboard.CreateButton().should('be.disabled');
@@ -78,7 +78,7 @@ describe('Public dashboards', () => {
// Select public dashboards tab
cy.intercept('GET', '/api/dashboards/uid/ZqZnVvFZz/public-dashboards').as('query-public-dashboard');
e2e.pages.ShareDashboardModal.PublicDashboard.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
cy.wait('@query-public-dashboard');
e2e.pages.ShareDashboardModal.PublicDashboard.CopyUrlInput().should('exist');
@@ -118,7 +118,7 @@ describe('Public dashboards', () => {
// Select public dashboards tab
cy.intercept('GET', '/api/dashboards/uid/ZqZnVvFZz/public-dashboards').as('query-public-dashboard');
e2e.pages.ShareDashboardModal.PublicDashboard.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
cy.wait('@query-public-dashboard');
// save url before disabling public dashboard
e2e/dashboards-suite/dashboard-public-templating.spec.ts
+1 -1
View File
@@ -13,7 +13,7 @@ describe('Create a public dashboard with template variables shows a template var
e2e.pages.Dashboard.DashNav.shareButton().click();
// Select public dashboards tab
e2e.pages.ShareDashboardModal.PublicDashboard.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
// Warning Alert dashboard cannot be made public because it has template variables
e2e.pages.ShareDashboardModal.PublicDashboard.TemplateVariablesWarningAlert().should('be.visible');
e2e/scenes/dashboards-suite/dashboard-public-create.spec.ts
+3 -3
View File
@@ -17,7 +17,7 @@ describe.skip('Public dashboards', () => {
e2e.components.NavToolbar.shareDashboard().click();
// Select public dashboards tab
e2e.pages.ShareDashboardModal.PublicDashboardScene.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
// Create button should be disabled
e2e.pages.ShareDashboardModal.PublicDashboard.CreateButton().should('be.disabled');
@@ -78,7 +78,7 @@ describe.skip('Public dashboards', () => {
// Select public dashboards tab
cy.intercept('GET', '/api/dashboards/uid/ZqZnVvFZz/public-dashboards').as('query-public-dashboard');
e2e.pages.ShareDashboardModal.PublicDashboardScene.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
cy.wait('@query-public-dashboard');
e2e.pages.ShareDashboardModal.PublicDashboard.CopyUrlInput().should('exist');
@@ -118,7 +118,7 @@ describe.skip('Public dashboards', () => {
// Select public dashboards tab
cy.intercept('GET', '/api/dashboards/uid/ZqZnVvFZz/public-dashboards').as('query-public-dashboard');
e2e.pages.ShareDashboardModal.PublicDashboardScene.Tab().click();
e2e.components.Tab.title('Public dashboard').click();
cy.wait('@query-public-dashboard');
// save url before disabling public dashboard
e2e/scenes/dashboards-suite/dashboard-public-templating.spec.ts
+1 -1
View File
@@ -13,7 +13,7 @@ describe('Create a public dashboard with template variables shows a template var
e2e.components.NavToolbar.shareDashboard().click();
// Select public dashboards tab
e2e.pages.ShareDashboardModal.PublicDashboardScene.Tab().click();
e2e.components.Tab.title('Public Dashboard').click();
// Warning Alert dashboard cannot be made public because it has template variables
e2e.pages.ShareDashboardModal.PublicDashboard.TemplateVariablesWarningAlert().should('be.visible');
e2e/scenes/dashboards-suite/snapshot-create.spec.ts
+1 -1
View File
@@ -25,7 +25,7 @@ describe('Snapshots', () => {
e2e.components.NavToolbar.shareDashboard().click();
// Select the snapshot tab
e2e.pages.ShareDashboardModal.SnapshotScene.Tab().click();
e2e.components.Tab.title('Snapshot').click();
// Publish snapshot
cy.intercept('POST', '/api/snapshots').as('save');