IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

remove dashboardId check... i can't figure out how the tests work

Browse Source
This commit is contained in:
ryan 2018-03-23 12:54:53 +01:00
parent e92ea79524
commit 7defb1adf5
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/api/annotations.go
View File

@ -63,11 +63,6 @@ func PostAnnotation(c *m.ReqContext, cmd dtos.PostAnnotationsCmd) Response {
return ApiError(500, "Failed to save annotation", err) return ApiError(500, "Failed to save annotation", err)
} }
if cmd.DashboardId == 0 {
err := &CreateAnnotationError{"Missing DashboardID"}
return ApiError(500, "Failed to save annotation", err)
}
item := annotations.Item{ item := annotations.Item{
OrgId: c.OrgId, OrgId: c.OrgId,
UserId: c.UserId, UserId: c.UserId,

9
pkg/api/annotations_test.go
View File

@ -14,11 +14,10 @@ import (
func TestAnnotationsApiEndpoint(t *testing.T) { func TestAnnotationsApiEndpoint(t *testing.T) {
Convey("Given an annotation without a dashboard id", t, func() { Convey("Given an annotation without a dashboard id", t, func() {
cmd := dtos.PostAnnotationsCmd{ cmd := dtos.PostAnnotationsCmd{
Time: 1000, Time: 1000,
Text: "annotation text", Text: "annotation text",
Tags: []string{"tag1", "tag2"}, Tags: []string{"tag1", "tag2"},
IsRegion: false, IsRegion: false,
DashboardId: 5,
} }
updateCmd := dtos.UpdateAnnotationsCmd{ updateCmd := dtos.UpdateAnnotationsCmd{