IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-01-27 00:37:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

data trails: alternate legend display for missing label value (#88153)

Browse Source 
* fix: alternate legend display for missing label value

* Update public/app/features/trails/ActionTabs/BreakdownScene.tsx

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

* Update public/app/features/trails/ActionTabs/BreakdownScene.tsx

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

---------

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>
This commit is contained in:
Darren Janeczek 2024-05-24 15:41:20 -04:00 committed by GitHub
parent a7d304a871
commit 80a0de511f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
public/app/features/trails/ActionTabs/BreakdownScene.tsx
View File

@ -21,6 +21,7 @@ import {
VariableDependencyConfig,
VizPanel,
} from '@grafana/scenes';
import { DataQuery } from '@grafana/schema';
import { Button, Field, useStyles2 } from '@grafana/ui';
import { ALL_VARIABLE_VALUE } from 'app/features/variables/constants';
@ -303,6 +304,7 @@ export function buildAllLayout(options: Array<SelectableValue<string>>, queryDef
)
.setHeaderActions(new SelectLabelAction({ labelName: String(option.value) }))
.setUnit(unit)
.setBehaviors([fixLegendForUnspecifiedLabelValueBehavior])
.build();
vizPanel.addActivationHandler(() => {
@ -456,3 +458,27 @@ function getBreakdownSceneFor(model: SceneObject): BreakdownScene {
throw new Error('Unable to find breakdown scene');
}
function fixLegendForUnspecifiedLabelValueBehavior(vizPanel: VizPanel) {
vizPanel.state.$data?.subscribeToState((newState, prevState) => {
const target = newState.data?.request?.targets[0];
if (hasLegendFormat(target)) {
const { legendFormat } = target;
// Assume {{label}}
const label = legendFormat.slice(2, -2);
newState.data?.series.forEach((series) => {
if (!series.fields[1].labels?.[label]) {
const labels = series.fields[1].labels;
if (labels) {
labels[label] = `<unspecified ${label}>`;
}
}
});
}
});
}
function hasLegendFormat(target: DataQuery | undefined): target is DataQuery & { legendFormat: string } {
return target !== undefined && 'legendFormat' in target && typeof target.legendFormat === 'string';
}