IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Plugins: Fixed issue for plugin extensions in link validator (#64739)

Browse Source 
fixed issue in validateLink.
This commit is contained in:
Marcus Andersson 2023-03-14 16:44:12 +01:00 committed by GitHub
parent 1e7c27e636
commit 8127ec5bfd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
public/app/features/plugins/extensions/validateLink.test.ts
View File

@ -30,6 +30,17 @@ describe('extension link validator', () => {
});
});
it('should return link configuration if path is not specified', () => {
const configureWithValidation = validator(() => {
return {
title: 'Go to page two',
};
});
const configured = configureWithValidation(extension, context);
expect(configured).toEqual({ title: 'Go to page two' });
});
it('should return undefined if path is invalid', () => {
const configureWithValidation = validator(() => {
return {

6
public/app/features/plugins/extensions/validateLink.ts
View File

@ -1,3 +1,5 @@
import { isString } from 'lodash';
import type { AppPluginExtensionLink } from '@grafana/data';
import type { ConfigureFunc } from './types';
@ -15,6 +17,10 @@ export function createLinkValidator(options: Options) {
return function validateLink(link, context) {
const configured = configure(link, context);
if (!isString(configured?.path)) {
return configured;
}
if (!isValidLinkPath(pluginId, configured?.path)) {
logger(
`[Plugins] Disabled extension '${title}' for '${pluginId}' beause configure didn't return a path with the correct prefix: '${`/a/${pluginId}/`}'`