Feat: Match allowed cookies with optional character (#71047)

* Match allowed cookies with optional character

* Use strings package
This commit is contained in:
ismail simsek
2023-07-05 17:12:56 +03:00
committed by GitHub
parent 971058919f
commit 81ba27c149
3 changed files with 133 additions and 1 deletions

View File

@@ -0,0 +1,60 @@
package datasources
import (
"encoding/json"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/grafana/grafana/pkg/components/simplejson"
)
func TestAllowedCookies(t *testing.T) {
testCases := []struct {
desc string
given map[string]interface{}
want []string
}{
{
desc: "Usual json data with keepCookies",
given: map[string]interface{}{
"keepCookies": []string{"cookie2"},
},
want: []string{"cookie2"},
},
{
desc: "Usual json data without kepCookies",
given: map[string]interface{}{
"something": "somethingelse",
},
want: []string(nil),
},
{
desc: "Usual json data that has multiple values in keepCookies",
given: map[string]interface{}{
"keepCookies": []string{"cookie1", "cookie2", "special[]"},
},
want: []string{"cookie1", "cookie2", "special[]"},
},
}
for _, test := range testCases {
t.Run(test.desc, func(t *testing.T) {
jsonDataBytes, err := json.Marshal(&test.given)
require.NoError(t, err)
jsonData, err := simplejson.NewJson(jsonDataBytes)
require.NoError(t, err)
ds := DataSource{
ID: 1235,
JsonData: jsonData,
UID: "test",
}
actual := ds.AllowedCookies()
assert.Equal(t, test.want, actual)
assert.EqualValues(t, test.want, actual)
})
}
}