mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
Chore: eslint react hook fix for public folder (#31174)
* Fixes under public/app/plugins * Fixes under public/app/plugins/datasource * Fixes under public/app/features * Fixes under public/app/features * Fixes under public/app/features * Fixes under public/app/components * Fix PanelNotSupported test * Fix one more warning * Fix warning in usePanelSave * Fix traceview empty response * Azure monitor fixes * More fixes * Fix tests for azure monitor * Fixes after merging master * Add comment for disabled rules * Fixes after merging master * Fixes after merging master * Adress review comments * Fix azure tests * Address review feedbacks
This commit is contained in:
@@ -28,7 +28,7 @@ export const SaveDashboardErrorProxy: React.FC<SaveDashboardErrorProxyProps> = (
|
||||
if (error.data && isHandledError(error.data.status)) {
|
||||
error.isHandled = true;
|
||||
}
|
||||
}, []);
|
||||
}, [error]);
|
||||
|
||||
return (
|
||||
<>
|
||||
|
||||
@@ -20,7 +20,7 @@ export const SaveProvisionedDashboardForm: React.FC<SaveDashboardFormProps> = ({
|
||||
type: 'application/json;charset=utf-8',
|
||||
});
|
||||
saveAs(blob, dashboard.title + '-' + new Date().getTime() + '.json');
|
||||
}, [dashboardJSON]);
|
||||
}, [dashboard.title, dashboardJSON]);
|
||||
|
||||
const onCopyToClipboardSuccess = useCallback(() => {
|
||||
appEvents.emit(AppEvents.alertSuccess, ['Dashboard JSON copied to clipboard']);
|
||||
|
||||
@@ -39,7 +39,7 @@ export const useDashboardSave = (dashboard: DashboardModel) => {
|
||||
locationService.replace(newUrl);
|
||||
}
|
||||
}
|
||||
}, [state]);
|
||||
}, [dashboard, state]);
|
||||
|
||||
return { state, onDashboardSave };
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user