diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index 13624b12500..01feba7cc2b 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -43,7 +43,6 @@ export interface FeatureToggles { storage?: boolean; dashboardsFromStorage?: boolean; export?: boolean; - storageLocalUpload?: boolean; azureMonitorResourcePickerForMetrics?: boolean; explore2Dashboard?: boolean; tracing?: boolean; diff --git a/pkg/api/api.go b/pkg/api/api.go index 619afbcfb73..9ab32650ac4 100644 --- a/pkg/api/api.go +++ b/pkg/api/api.go @@ -227,17 +227,16 @@ func (hs *HTTPServer) registerRoutes() { }) if hs.Features.IsEnabled(featuremgmt.FlagStorage) { - apiRoute.Group("/storage", func(orgRoute routing.RouteRegister) { - orgRoute.Get("/list/", routing.Wrap(hs.StorageService.List)) - orgRoute.Get("/list/*", routing.Wrap(hs.StorageService.List)) - orgRoute.Get("/read/*", routing.Wrap(hs.StorageService.Read)) + apiRoute.Group("/storage", func(storageRoute routing.RouteRegister) { + storageRoute.Get("/list/", routing.Wrap(hs.StorageService.List)) + storageRoute.Get("/list/*", routing.Wrap(hs.StorageService.List)) + storageRoute.Get("/read/*", routing.Wrap(hs.StorageService.Read)) - if hs.Features.IsEnabled(featuremgmt.FlagStorageLocalUpload) { - orgRoute.Post("/delete/*", reqGrafanaAdmin, routing.Wrap(hs.StorageService.Delete)) - orgRoute.Post("/upload", reqGrafanaAdmin, routing.Wrap(hs.StorageService.Upload)) - orgRoute.Post("/createFolder", reqGrafanaAdmin, routing.Wrap(hs.StorageService.CreateFolder)) - orgRoute.Post("/deleteFolder", reqGrafanaAdmin, routing.Wrap(hs.StorageService.DeleteFolder)) - } + // Write paths + storageRoute.Post("/delete/*", reqGrafanaAdmin, routing.Wrap(hs.StorageService.Delete)) + storageRoute.Post("/upload", reqGrafanaAdmin, routing.Wrap(hs.StorageService.Upload)) + storageRoute.Post("/createFolder", reqGrafanaAdmin, routing.Wrap(hs.StorageService.CreateFolder)) + storageRoute.Post("/deleteFolder", reqGrafanaAdmin, routing.Wrap(hs.StorageService.DeleteFolder)) }) } diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 2ce3890e4d0..f596d919ae4 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -152,12 +152,6 @@ var ( State: FeatureStateAlpha, RequiresDevMode: true, }, - { - Name: "storageLocalUpload", - Description: "allow uploads to local storage", - State: FeatureStateAlpha, - RequiresDevMode: true, - }, { Name: "azureMonitorResourcePickerForMetrics", Description: "New UI for Azure Monitor Metrics Query", diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index aa9c44edccf..a0684dcc9c7 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -115,10 +115,6 @@ const ( // Export grafana instance (to git, etc) FlagExport = "export" - // FlagStorageLocalUpload - // allow uploads to local storage - FlagStorageLocalUpload = "storageLocalUpload" - // FlagAzureMonitorResourcePickerForMetrics // New UI for Azure Monitor Metrics Query FlagAzureMonitorResourcePickerForMetrics = "azureMonitorResourcePickerForMetrics" diff --git a/pkg/services/store/service.go b/pkg/services/store/service.go index f251484956b..480fee1b6eb 100644 --- a/pkg/services/store/service.go +++ b/pkg/services/store/service.go @@ -108,15 +108,16 @@ func ProvideService(sql *sqlstore.SQLStore, features featuremgmt.FeatureToggles, initializeOrgStorages := func(orgId int64) []storageRuntime { storages := make([]storageRuntime, 0) - if features.IsEnabled(featuremgmt.FlagStorageLocalUpload) { - storages = append(storages, - newSQLStorage(RootResources, - "Resources", - &StorageSQLConfig{orgId: orgId}, sql). - setBuiltin(true). - setDescription("Upload custom resource files")) - } + // Custom upload files + storages = append(storages, + newSQLStorage(RootResources, + "Resources", + &StorageSQLConfig{orgId: orgId}, sql). + setBuiltin(true). + setDescription("Upload custom resource files")) + + // System settings storages = append(storages, newSQLStorage(RootSystem, "System", diff --git a/public/app/features/dimensions/editors/ResourcePickerPopover.tsx b/public/app/features/dimensions/editors/ResourcePickerPopover.tsx index 3627a3de511..aa1d2f3b93b 100644 --- a/public/app/features/dimensions/editors/ResourcePickerPopover.tsx +++ b/public/app/features/dimensions/editors/ResourcePickerPopover.tsx @@ -94,16 +94,6 @@ export const ResourcePickerPopover = (props: Props) => { - {config.featureToggles['storageLocalUpload'] ? ( - - ) : ( - '' - )}