IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-20 11:48:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

TestData: Fix issue with numeric inputs in TestData query editor (#28936)

Browse Source
This commit is contained in:
Torkel Ödegaard 2020-11-09 14:48:08 +01:00 committed by GitHub
parent ef2de2d357
commit 8499d1408d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
public/app/plugins/datasource/testdata/QueryEditor.tsx vendored
View File

@ -23,9 +23,6 @@ const endpoints = [
{ value: 'annotations', label: 'Annotations' },
];
// Fields that need to be transformed to numbers
const numberFields = ['lines', 'seriesCount', 'timeStep'];
const selectors = editorSelectors.components.DataSource.TestData.QueryTab;
export interface EditorProps {
@ -80,22 +77,29 @@ export const QueryEditor = ({ query, datasource, onChange, onRunQuery }: Props)
};
const onInputChange = (e: FormEvent<HTMLInputElement | HTMLTextAreaElement>) => {
const { name, value } = e.target as HTMLInputElement | HTMLTextAreaElement;
let newValue: Partial<TestDataQuery> = { [name]: value };
const { name, value, type } = e.target as HTMLInputElement | HTMLTextAreaElement;
let newValue: any = value;
if (name === 'levelColumn') {
newValue = { levelColumn: (e.target as HTMLInputElement).checked };
} else if (numberFields.includes(name)) {
newValue = { [name]: Number(value) };
if (type === 'number') {
newValue = Number(value);
}
onUpdate({ ...query, ...newValue });
if (name === 'levelColumn') {
newValue = (e.target as HTMLInputElement).checked;
}
onUpdate({ ...query, [name]: newValue });
};
const onFieldChange = (field: string) => (e: ChangeEvent<HTMLInputElement>) => {
const { name, value } = e.target as HTMLInputElement;
const formattedValue = numberFields.includes(name) ? Number(value) : value;
onUpdate({ ...query, [field]: { ...query[field as keyof TestDataQuery], [name]: formattedValue } });
const { name, value, type } = e.target as HTMLInputElement;
let newValue: any = value;
if (type === 'number') {
newValue = Number(value);
}
onUpdate({ ...query, [field]: { ...query[field as keyof TestDataQuery], [name]: newValue } });
};
const onEndPointChange = ({ value }: SelectableValue) => {