From 86844142a9d55cc0d5dbc633f9b0a57e6ba0a09e Mon Sep 17 00:00:00 2001 From: Ashley Harrison Date: Wed, 4 Sep 2024 16:20:00 +0100 Subject: [PATCH] Translations: Crowdin action now works on subsequent pushes (#92939) * try using the generated token in the checkout action * comment out github_user_name * try adding with: token * try env var * try removing github_user_name * restore user_name etc * update action * try persist-credentials: false; * remove persist-creds false * test * restore github actions name --- .github/workflows/i18n-crowdin-download.yml | 11 ++++++----- .github/workflows/i18n-crowdin-upload.yml | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/i18n-crowdin-download.yml b/.github/workflows/i18n-crowdin-download.yml index 440ee9068ba..cba14abe43b 100644 --- a/.github/workflows/i18n-crowdin-download.yml +++ b/.github/workflows/i18n-crowdin-download.yml @@ -14,10 +14,6 @@ jobs: pull-requests: write # needed to update PR description, labels, etc steps: - - uses: actions/checkout@v4 - with: - ref: ${{ github.head_ref }} - - name: Generate token id: generate_token uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92 @@ -25,9 +21,14 @@ jobs: app_id: ${{ secrets.GRAFANA_PR_AUTOMATION_APP_ID }} private_key: ${{ secrets.GRAFANA_PR_AUTOMATION_APP_PEM }} + - uses: actions/checkout@v4 + with: + ref: ${{ github.head_ref }} + token: ${{ steps.generate_token.outputs.token }} + - name: Download sources id: crowdin-download - uses: crowdin/github-action@v1 + uses: crowdin/github-action@v2 with: upload_sources: false upload_translations: false diff --git a/.github/workflows/i18n-crowdin-upload.yml b/.github/workflows/i18n-crowdin-upload.yml index 9e028b5386f..39a89c5aad2 100644 --- a/.github/workflows/i18n-crowdin-upload.yml +++ b/.github/workflows/i18n-crowdin-upload.yml @@ -17,7 +17,7 @@ jobs: uses: actions/checkout@v4 - name: Upload sources - uses: crowdin/github-action@v1 + uses: crowdin/github-action@v2 with: upload_sources: true upload_sources_args: '--dest=public/locales/en-US/grafana.json'