From 87717849da0ca298e321a92876ee63a187fe1056 Mon Sep 17 00:00:00 2001 From: Kat Yang <69819079+yangkb09@users.noreply.github.com> Date: Tue, 31 Oct 2023 11:46:48 -0400 Subject: [PATCH] Chore: Deprecate FolderID in GetLibraryElementCommand (#77404) --- pkg/services/folder/folderimpl/folder_test.go | 4 ++-- pkg/services/libraryelements/database.go | 1 + pkg/services/libraryelements/model/model.go | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/services/folder/folderimpl/folder_test.go b/pkg/services/folder/folderimpl/folder_test.go index 3b4fd217c92..14d01a34489 100644 --- a/pkg/services/folder/folderimpl/folder_test.go +++ b/pkg/services/folder/folderimpl/folder_test.go @@ -661,14 +661,14 @@ func TestIntegrationNestedFolderService(t *testing.T) { _, err = lps.LibraryElementService.GetElement(context.Background(), &signedInUser, model.GetLibraryElementCommand{ FolderName: parent.Title, - FolderID: parent.ID, + FolderID: parent.ID, // nolint:staticcheck UID: parentPanel.UID, }) require.ErrorIs(t, err, tc.libPanelParentErr) if tc.depth > 1 { _, err = lps.LibraryElementService.GetElement(context.Background(), &signedInUser, model.GetLibraryElementCommand{ FolderName: subfolder.Title, - FolderID: subfolder.ID, + FolderID: subfolder.ID, // nolint:staticcheck UID: subPanel.UID, }) require.ErrorIs(t, err, tc.libPanelSubErr) diff --git a/pkg/services/libraryelements/database.go b/pkg/services/libraryelements/database.go index d2614d6af50..b2a6d68b686 100644 --- a/pkg/services/libraryelements/database.go +++ b/pkg/services/libraryelements/database.go @@ -277,6 +277,7 @@ func (l *LibraryElementService) getLibraryElements(c context.Context, store db.D builder.Write(", ? as folder_name ", cmd.FolderName) builder.Write(", '' as folder_uid ") builder.Write(getFromLibraryElementDTOWithMeta(store.GetDialect())) + // nolint:staticcheck writeParamSelectorSQL(&builder, append(params, Pair{"folder_id", cmd.FolderID})...) builder.Write(" UNION ") builder.Write(selectLibraryElementDTOWithMeta) diff --git a/pkg/services/libraryelements/model/model.go b/pkg/services/libraryelements/model/model.go index 194e6620b18..5012c7c9c2c 100644 --- a/pkg/services/libraryelements/model/model.go +++ b/pkg/services/libraryelements/model/model.go @@ -233,8 +233,9 @@ type PatchLibraryElementCommand struct { // GetLibraryElementCommand is the command for getting a library element. type GetLibraryElementCommand struct { FolderName string - FolderID int64 - UID string + // Deprecated: use FolderUID instead + FolderID int64 + UID string } // SearchLibraryElementsQuery is the query used for searching for Elements